Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: remove blocking return #31960

Merged
merged 1 commit into from
Feb 13, 2020
Merged

CLN: remove blocking return #31960

merged 1 commit into from
Feb 13, 2020

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Feb 13, 2020 •
edited
Loading

just noticed a return statement in the middle of a test that prevents it from being executed. This was added in ##23752

@MarcoGorelli MarcoGorelli changed the title remove blocking return CLN: remove blocking return Feb 13, 2020
@simonjayhawkins simonjayhawkins added Clean Testing pandas testing functions or related to the test suite labels Feb 13, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Feb 13, 2020
@simonjayhawkins simonjayhawkins merged commit e8eb49d into pandas-dev:master Feb 13, 2020
@simonjayhawkins
Copy link
Member

Thanks @MarcoGorelli

@MarcoGorelli MarcoGorelli deleted the remove-blocking-return branch February 19, 2020 10:49
roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
@MarcoGorelli @roberthdevries
remove blocking return (pandas-dev#31960)
82e493a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoGorelli @simonjayhawkins