Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB: Improving the sponsors in the web, and adding CZI #31046

Merged
merged 2 commits into from
Jan 17, 2020
Merged

WEB: Improving the sponsors in the web, and adding CZI #31046

merged 2 commits into from
Jan 17, 2020

Conversation

datapythonista
Copy link
Member

Things addressed here:

  • Added CZI as sponsor
  • Adding an arbitrary number of sponsor logos in the home (previously the style only worked for 6)
  • Adding a Become a sponsor section to the sponsors page
  • Moving all sponsors to the web yaml, and standardizing how we present them in the sponsors page

Screenshot at 2020-01-15 16-22-57

Screenshot at 2020-01-15 16-23-32

Sorry, something went wrong.

@datapythonista datapythonista added the Web pandas website label Jan 15, 2020
You can support pandas by becoming a Tidelift subscriber.
As a free and open source project, _pandas_ relies on the support of the community of users for its development.
If you work for an organization that uses and benefits from _pandas_, please consider supporting pandas. There
are different ways, such as employing people to work on pandas, funds the project, or becoming a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"funding" instead of "funds", to be consistent with "employing" and "becoming"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, thanks!

description: "<i>pandas</i> is part of the <a href=\"https://tidelift.com/subscription/pkg/pypi-pandas?utm_source=pypi-pandas&utm_medium=referral&utm_campaign=readme\">Tidelift subscription</a>. You can support pandas by becoming a Tidelift subscriber."
- name: "Chan Zuckerberg Initiative"
url: https://chanzuckerberg.com/
logo: /static/img/partners/czi.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be pulled from the web rather than included in our repo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's surely an option. My preference is to copy the image, since it's quite small, and we have control and certainty about its content (it won't break if CZI renames the file, or we won't get a logo with a santa hat for xmas, if they decide this looks cool in their website...).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather pull from the web; one less file in the repo and on the flip side if they update we aren't out of date

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do that, we should do it for all the sponsors that have the logo we need online. Doing it just for CZI doesn't make a lot of sense.

I can remove CZI from this PR, so we can get the rest of the styling and cleaning merged, and we can work on the logos and add CZI later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh didn't realize we did this for others. OK for now then

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@datapythonista datapythonista merged commit b68a9bb into pandas-dev:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web pandas website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Add CZI to the sponsors page
3 participants