-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WEB: Improving the sponsors in the web, and adding CZI #31046
Conversation
web/pandas/about/sponsors.md
Outdated
You can support pandas by becoming a Tidelift subscriber. | ||
As a free and open source project, _pandas_ relies on the support of the community of users for its development. | ||
If you work for an organization that uses and benefits from _pandas_, please consider supporting pandas. There | ||
are different ways, such as employing people to work on pandas, funds the project, or becoming a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"funding" instead of "funds", to be consistent with "employing" and "becoming"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, thanks!
description: "<i>pandas</i> is part of the <a href=\"https://tidelift.com/subscription/pkg/pypi-pandas?utm_source=pypi-pandas&utm_medium=referral&utm_campaign=readme\">Tidelift subscription</a>. You can support pandas by becoming a Tidelift subscriber." | ||
- name: "Chan Zuckerberg Initiative" | ||
url: https://chanzuckerberg.com/ | ||
logo: /static/img/partners/czi.svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be pulled from the web rather than included in our repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's surely an option. My preference is to copy the image, since it's quite small, and we have control and certainty about its content (it won't break if CZI renames the file, or we won't get a logo with a santa hat for xmas, if they decide this looks cool in their website...).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather pull from the web; one less file in the repo and on the flip side if they update we aren't out of date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do that, we should do it for all the sponsors that have the logo we need online. Doing it just for CZI doesn't make a lot of sense.
I can remove CZI from this PR, so we can get the rest of the styling and cleaning merged, and we can work on the logos and add CZI later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh didn't realize we did this for others. OK for now then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Things addressed here:
Become a sponsor
section to the sponsors page