Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF: masked ops for reductions (sum) #30982

Merged
merged 24 commits into from
Mar 27, 2020
Merged

PERF: masked ops for reductions (sum) #30982

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
9795f35
POC masked ops for reductions
jorisvandenbossche Jan 13, 2020
7fb1f88
Merge remote-tracking branch 'upstream/master' into masked-ops
jorisvandenbossche Feb 13, 2020
cd26920
fix mask for older numpy
jorisvandenbossche Feb 13, 2020
28cd331
also use in boolean
jorisvandenbossche Feb 13, 2020
6298fbd
add min_count support
jorisvandenbossche Feb 13, 2020
735a741
fix preserve_dtypes test
jorisvandenbossche Feb 13, 2020
6df454f
passthrough min_count for boolean as well
jorisvandenbossche Feb 13, 2020
5eb48d6
fix comment
jorisvandenbossche Feb 13, 2020
3ef1331
Merge remote-tracking branch 'upstream/master' into masked-ops
jorisvandenbossche Feb 20, 2020
d2230fd
add object to empty reduction test case
jorisvandenbossche Feb 20, 2020
19ac821
test platform int
jorisvandenbossche Feb 21, 2020
2776436
Test sum separately with platform int
jorisvandenbossche Feb 21, 2020
68b4dc2
Merge remote-tracking branch 'upstream/master' into masked-ops
jorisvandenbossche Mar 20, 2020
18d5bfa
share min_count checking helper function with nanops
jorisvandenbossche Mar 20, 2020
457efb1
Merge remote-tracking branch 'upstream/master' into masked-ops
jorisvandenbossche Mar 23, 2020
4df858f
type + add docstring for min_count
jorisvandenbossche Mar 23, 2020
f5120db
Merge remote-tracking branch 'upstream/master' into masked-ops
jorisvandenbossche Mar 25, 2020
76c5149
move sum algo from ops to array_algos
jorisvandenbossche Mar 25, 2020
476f768
Merge remote-tracking branch 'upstream/master' into masked-ops
jorisvandenbossche Mar 26, 2020
b2162dc
add Int64/boolean to some benchmarks
jorisvandenbossche Mar 26, 2020
d4746f5
add whatsnew
jorisvandenbossche Mar 26, 2020
d9c2cbf
add skipna default in function signature
jorisvandenbossche Mar 26, 2020
f8705c2
update type hint + deprivatize
jorisvandenbossche Mar 26, 2020
1a43e10
update another type hint
jorisvandenbossche Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update another type hint
  • Loading branch information
@jorisvandenbossche
jorisvandenbossche committed Mar 26, 2020
commit 1a43e1058cdc12fc0a05e7a990a16e11f463e45d
2 changes: 1 addition & 1 deletion pandas/core/nanops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1238,7 +1238,7 @@ def _maybe_null_out(
result: np.ndarray,
axis: Optional[int],
mask: Optional[np.ndarray],
shape: Tuple[int],
shape: Tuple[int, ...],
min_count: int = 1,
) -> float:
"""
Expand Down