Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASV: use pandas.util.testing for back compat #30779

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

jorisvandenbossche
Copy link
Member

cc @TomAugspurger I propose to keep the old deprecated imports (as long as they are not removed), so the benchmarks can still be run when eg doing a comparison of 0.25 with current master.

@jorisvandenbossche jorisvandenbossche added the Benchmark Performance (ASV) benchmarks label Jan 7, 2020
@jorisvandenbossche jorisvandenbossche added this to the 1.0 milestone Jan 7, 2020
@jorisvandenbossche
Copy link
Member Author

Actually, maybe doing a try/except is a better option (this can be put in pandas_vb_common.py, we have something similar for lib)

@TomAugspurger
Copy link
Contributor

A try / except sounds better to me, so we don't have the warnings in the logs.

@jreback
Copy link
Contributor

jreback commented Jan 7, 2020

A try / except sounds better to me, so we don't have the warnings in the logs.

maybe we just filter out FutureWarnings from asvs? (generally)

@TomAugspurger
Copy link
Contributor

Though we'll need to make the changes at some point, for when we enforce the deprecation. Don't have a preference.

@jorisvandenbossche
Copy link
Member Author

Though we'll need to make the changes at some point, for when we enforce the deprecation.

When using the try/except, that is in principle not needed (until the point we want to clean up compatibility with older pandas versions in the benchmarks of course, but that doesn't necessarily need be at the same time as when enforcing the deprecation)

@jreback jreback merged commit cea6853 into pandas-dev:master Jan 7, 2020
@jreback
Copy link
Contributor

jreback commented Jan 7, 2020

thanks @jorisvandenbossche

@jorisvandenbossche jorisvandenbossche deleted the benchmarks-run branch January 8, 2020 07:34
@jorisvandenbossche
Copy link
Member Author

@jreback given the discussion, this was not really ready

@jorisvandenbossche
Copy link
Member Author

See #30810 for a PR based on the discussion above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants