DEPR: pandas.util.testing #30620
DEPR: pandas.util.testing #30620
Conversation
|
On second thought, we may want to hold of on making the |
|
The naming is problematic for our isort config. We treat |
|
Moved to pandas._testing. |
|
Not sure about the mypy failure. I saw this in #29964 too, but have never reproduced locally. |
|
I see it locally occasionally. Seems pretty random.
…On Thu, Jan 2, 2020 at 2:28 PM Tom Augspurger ***@***.***> wrote:
Not sure about the mypy failure.
mypy --version
mypy 0.730
Performing static analysis using mypy
pandas/tests/test_register_accessor.py:39: error: Module has no attribute "register_series_accessor"
pandas/tests/test_register_accessor.py:40: error: Module has no attribute "register_dataframe_accessor"
pandas/tests/test_register_accessor.py:41: error: Module has no attribute "register_index_accessor"
Found 3 errors in 1 file (checked 839 source files)
I saw this in #29964 <#29964>
too, but have never reproduced locally.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#30620?email_source=notifications&email_token=AB5UM6DVFJ67N3L3I3LAMHTQ3ZS7XA5CNFSM4KCEWVK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH7USKA#issuecomment-570378536>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5UM6A7CXXCFTNMGOGTMUTQ3ZS7XANCNFSM4KCEWVKQ>
.
|
|
lgtm. |
|
Haven't seen the error before - does merging master resolve?
I don't think we want this. I'm under the impression these are better converted to fixtures |
|
Sounds good. Planning to merge this once it passes since it touch so many files. |
|
Another mypy failure. |
i see this locally quite often on my check_untyped_defs branch. can normally clear with |
|
Not sure if it's relevant, but we seem to only import |
|
Passing now. Merging. |
| @@ -26,6 +28,16 @@ Testing functions | |||
| testing.assert_frame_equal | |||
| testing.assert_series_equal | |||
| testing.assert_index_equal | |||
| testing.assert_equal | |||
| testing.assert_almost_equal | |||
| testing.assert_categorical_equal | |||
There was a problem hiding this comment.
Is it needed to make all those asserts public?
Eg, what's the pandas-specific value for external projects of using pandas' assert_equal or assert_almost_equal ?
Also all the EA specific ones could probably be limited to a single general array assert?
There was a problem hiding this comment.
Thoughts about this? (can also make an issue for it)
Closes #16232.
I tried to keep the commits somewhat clean.
e96624b and d52d35f can probably be ignored. That's just moving
pandas.util.testingtopandas.util._testingand updating all the relevant imports.Main question: do we want to make the
tm.make*methods public? I'd say we probably should, but wanted to confirm.