Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup pip env #29445

Merged
merged 1 commit into from
Nov 7, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
numpy>=1.15
python==3.7
python-dateutil>=2.6.1
pytz
asv
Expand Down
8 changes: 4 additions & 4 deletions scripts/generate_pip_deps_from_conda.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

import yaml

EXCLUDE = {"python=3"}
EXCLUDE = {"python"}
RENAME = {"pytables": "tables", "pyqt": "pyqt5", "dask-core": "dask"}


Expand All @@ -33,15 +33,15 @@ def conda_package_to_pip(package):
- A package requiring a specific version, in conda is defined with a single
equal (e.g. ``pandas=1.0``) and in pip with two (e.g. ``pandas==1.0``)
"""
if package in EXCLUDE:
return

package = re.sub("(?<=[^<>])=", "==", package).strip()

for compare in ("<=", ">=", "=="):
if compare not in package:
continue

pkg, version = package.split(compare)
if pkg in EXCLUDE:
return

if pkg in RENAME:
return "".join((RENAME[pkg], compare, version))
Expand Down