CLN: catch Exception less #28309
Merged
CLN: catch Exception less #28309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Sep 6, 2019
| try: | ||
| return x.shape[axis] > 0 | ||
| except Exception: | ||
| if x.ndim <= axis: |
There was a problem hiding this comment.
Hmm I guess this replicates existing behavior but is this really right? Seems counter intuitive to return True in a function called is_nonempty if the axis doesn't exist at all
There was a problem hiding this comment.
the comment just above the function "1-d dtypes always are included here" seems to address that. i agree it could be clearer, but I'm not going to lose sleep over it. ideas for better wording?
|
thanks |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.