-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated Series.ftype, Series.ftypes and DataFrame.ftypes features #26744
Conversation
# Conflicts: # doc/make.py
# Updated unit tests and doc strings to reflect the changes.
@jreback @jorisvandenbossche - Any idea why these builds are failing? |
Codecov Report
@@ Coverage Diff @@
## master #26744 +/- ##
==========================================
- Coverage 91.78% 91.77% -0.01%
==========================================
Files 174 174
Lines 50706 50709 +3
==========================================
- Hits 46541 46540 -1
- Misses 4165 4169 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26744 +/- ##
==========================================
- Coverage 91.78% 90.31% -1.48%
==========================================
Files 174 178 +4
Lines 50706 50774 +68
==========================================
- Hits 46541 45854 -687
- Misses 4165 4920 +755
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine, pls add a note in the whatsnew Deprecation section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThiviyanThanapalasingam thanks for the PR!
I added a bunch of small suggestions (just some wording to be more explicit), normally you should be able to accept those suggestions through the github UI.
Looks good for the rest!
Co-Authored-By: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-Authored-By: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-Authored-By: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-Authored-By: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-Authored-By: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-Authored-By: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-Authored-By: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Great! Appreciate the feedback. |
thanks @ThiviyanThanapalasingam |
Deprecation of
Series.ftype
,Series.ftypes
andDataFrame.ftypes
closes #26705