CLN: remove sample_time attributes from benchmarks #26598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These appear to have been brought in by direct replacement of a deprecated ASV attribute goal_time -> sample_time, but the two have different semantics. Increasing this from the default value is probably not necessary and increases runtime, so it's better to restore it to defaults.
Codecov Report
@@ Coverage Diff @@
## master #26598 +/- ##
==========================================
- Coverage 91.84% 91.84% -0.01%
==========================================
Files 174 174
Lines 50644 50644
==========================================
- Hits 46516 46512 -4
- Misses 4128 4132 +4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #26598 +/- ##
==========================================
- Coverage 91.84% 91.84% -0.01%
==========================================
Files 174 174
Lines 50644 50644
==========================================
- Hits 46516 46512 -4
- Misses 4128 4132 +4
Continue to review full report at Codecov.
|
|
thanks @pv always welcome comments on the asv structure :-> |
vaibhavhrt
pushed a commit
to vaibhavhrt/pandas
that referenced
this pull request
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very minor benchmark cleanup now that I was on it...
These attributes appear to have been brought in by direct replacement of a
deprecated ASV attribute goal_time -> sample_time, but the two have
different semantics (the value sample_time=0.2 is 20x the default).
Increasing this from the default value is probably not necessary and
increases runtime (here 3min vs 17min for rolling.*), so it's better to restore it to defaults.