Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Remove compat.re_type #26279

Merged
merged 1 commit into from
May 5, 2019
Merged

Conversation

topper-123
Copy link
Contributor

This removes compat.re_type from the code base.

@WillAyd WillAyd added the Clean label May 3, 2019
@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #26279 into master will decrease coverage by 51.26%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #26279       +/-   ##
===========================================
- Coverage   91.98%   40.72%   -51.27%     
===========================================
  Files         175      175               
  Lines       52379    52377        -2     
===========================================
- Hits        48183    21329    -26854     
- Misses       4196    31048    +26852
Flag Coverage Δ
#multiple ?
#single 40.72% <100%> (-0.16%) ⬇️
Impacted Files Coverage Δ
pandas/compat/__init__.py 81.08% <ø> (-13.8%) ⬇️
pandas/core/dtypes/inference.py 83.6% <100%> (-16.4%) ⬇️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.37%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.16%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.1%) ⬇️
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f46ab96...a402489. Read the comment docs.

@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #26279 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26279      +/-   ##
==========================================
- Coverage   91.98%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52379    52377       -2     
==========================================
- Hits        48183    48178       -5     
- Misses       4196     4199       +3
Flag Coverage Δ
#multiple 90.53% <100%> (-0.01%) ⬇️
#single 40.72% <100%> (-0.16%) ⬇️
Impacted Files Coverage Δ
pandas/compat/__init__.py 94.59% <ø> (-0.28%) ⬇️
pandas/core/dtypes/inference.py 100% <100%> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.71% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f46ab96...a402489. Read the comment docs.

@topper-123 topper-123 changed the title CLN: clean compat.re_type CLN: Remove compat.re_type May 4, 2019
@gfyoung gfyoung added this to the 0.25.0 milestone May 5, 2019
@gfyoung gfyoung merged commit 560ad35 into pandas-dev:master May 5, 2019
@gfyoung
Copy link
Member

gfyoung commented May 5, 2019

Thanks @topper-123 !

@topper-123 topper-123 deleted the clean_re_type branch May 5, 2019 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants