Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add errors parameter to DataFrame.rename #25535

Merged
merged 8 commits into from
Mar 5, 2019
+74 −11
Merged

ENH: Add errors parameter to DataFrame.rename #25535

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
45ccb39
ENH: GH13473 Add errors parameter to DataFrame.rename
MaxVanDeursen Mar 4, 2019
011e2c1
ENH: GH13473 Change KeyError to only include missing labels
MaxVanDeursen Mar 4, 2019
383bc59
ENH: Check that v is not a callable (#13473)
MaxVanDeursen Mar 4, 2019
79ace76
ENH: Correct documentation of DataFrame.rename (#13473)
MaxVanDeursen Mar 4, 2019
3095c5f
ENH: Change signature assertion (#13473)
MaxVanDeursen Mar 4, 2019
e67223d
ENH: Implement feedback (#13473)
MaxVanDeursen Mar 5, 2019
525f8c5
ENH: Implement feedback (#13473)
MaxVanDeursen Mar 5, 2019
97746e8
ENH: Rename renamed to result in testcase (#13473)
MaxVanDeursen Mar 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ENH: Change signature assertion (#13473)
@MaxVanDeursen
MaxVanDeursen committed Mar 4, 2019
commit 3095c5f84497755a02b23b8ff15f84d3f5fd7a53
2 changes: 1 addition & 1 deletion pandas/tests/frame/test_alter_axes.py
View file
Original file line number Diff line number Diff line change
@@ -1351,7 +1351,7 @@ def test_rename_signature(self):
sig = inspect.signature(DataFrame.rename)
parameters = set(sig.parameters)
assert parameters == {"self", "mapper", "index", "columns", "axis",
"inplace", "copy", "level"}
"inplace", "copy", "level", "errors"}

@pytest.mark.skipif(PY2, reason="inspect.signature")
def test_reindex_signature(self):