CLN: Excel Module Cleanups pandas-dev #25271 #25340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #25340 +/- ##
==========================================
- Coverage 91.72% 91.72% -0.01%
==========================================
Files 173 173
Lines 52831 52830 -1
==========================================
- Hits 48457 48456 -1
Misses 4374 4374
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #25340 +/- ##
==========================================
- Coverage 91.72% 91.72% -0.01%
==========================================
Files 173 173
Lines 52831 52830 -1
==========================================
- Hits 48457 48456 -1
Misses 4374 4374
Continue to review full report at Codecov.
|
|
Thanks for the interest and doing a PR! Unfortunately there is already another one for this so will stick with that one since it came first.
…Sent from my iPhone
On Feb 16, 2019, at 4:13 AM, codecov[bot] ***@***.***> wrote:
Codecov Report
Merging #25340 into master will decrease coverage by <.01%.
The diff coverage is 100%.
@@ Coverage Diff @@
## master #25340 +/- ##
==========================================
- Coverage 91.72% 91.72% -0.01%
==========================================
Files 173 173
Lines 52831 52830 -1
==========================================
- Hits 48457 48456 -1
Misses 4374 4374
Flag Coverage Δ
#multiple 90.28% <100%> (-0.01%) ⬇️
#single 41.72% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/excel/_util.py 80.64% <ø> (ø) ⬆️
pandas/io/excel/_base.py 92.48% <100%> (-0.04%) ⬇️
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83fe6ca...985e354. Read the comment docs.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
closing in favor of #25275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff