-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Update DataFrame.eq docstring #24774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I didn't quite understand what was the problem. But there are many validations that we can't add to the CI yet, because we have many cases still failing, |
We made an API change, and broke the example in the docs. So not including |
Ah, sorry, I got it now. We've got two ways of running the doctests, |
Codecov Report
@@ Coverage Diff @@
## master #24774 +/- ##
==========================================
- Coverage 92.38% 92.38% -0.01%
==========================================
Files 166 166
Lines 52363 52363
==========================================
- Hits 48377 48376 -1
- Misses 3986 3987 +1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #24774 +/- ##
==========================================
- Coverage 92.38% 92.38% -0.01%
==========================================
Files 166 166
Lines 52363 52363
==========================================
- Hits 48377 48376 -1
- Misses 3986 3987 +1
Continue to review full report at Codecov.
|
Unfortunately, we can't use It's not clear to be how best to handle this CI-wise. Pushing on fixing the exceptions in the docstrings is probably the best path forward. |
thanks @TomAugspurger |
This was failing due to http://pandas.pydata.org/pandas-docs/version/0.24.0rc1/whatsnew/v0.24.0.html#dataframe-comparison-operations-broadcasting-changes
I'm surprised the doctests didn't catch this. @datapythonista,
pandas.DataFrame.eq
is included in the API docs at http://pandas-docs.github.io/pandas-docs-travis/api/generated/pandas.DataFrame.eq.html. I believe it's because EX02 isn't passed in the code checks. @datapythonista do you know if that's deliberate?