-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: remove redundant mac wheel-build code #24644
Conversation
great! |
were you able to build the wheels on a fork to test? |
yes, although its getting difficult as the mac builds on the wheel builder are starting to hit the travis job timeout (50min) |
great @robbuckley yeah I think the timeouts are separate (I pushed a fix to see) |
Codecov Report
@@ Coverage Diff @@
## master #24644 +/- ##
=======================================
Coverage 92.37% 92.37%
=======================================
Files 166 166
Lines 52379 52379
=======================================
Hits 48386 48386
Misses 3993 3993
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #24644 +/- ##
=======================================
Coverage 92.37% 92.37%
=======================================
Files 166 166
Lines 52379 52379
=======================================
Hits 48386 48386
Misses 3993 3993
Continue to review full report at Codecov.
|
thanks @robbuckley |
btw I put in place pytest-xdist on the wheels, so finish in about 40 min now :> |
git diff upstream/master -u -- "*.py" | flake8 --diff
this code is redundant for wheels built using https://github.com/MacPython/pandas-wheels, as the line https://github.com/matthew-brett/multibuild/blob/266d88fe1e474748cc8a3823dc3934bf55e76383/osx_utils.sh#L306 adds tags for 10.9 and 10.10.
Note: circleci fails as I forgot to turn it off on my fork, after it was turned off upstream