Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: remove redundant mac wheel-build code #24644

Merged
merged 1 commit into from
Jan 5, 2019

Conversation

robbuckley
Copy link
Contributor

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

this code is redundant for wheels built using https://github.com/MacPython/pandas-wheels, as the line https://github.com/matthew-brett/multibuild/blob/266d88fe1e474748cc8a3823dc3934bf55e76383/osx_utils.sh#L306 adds tags for 10.9 and 10.10.

Note: circleci fails as I forgot to turn it off on my fork, after it was turned off upstream

@jreback
Copy link
Contributor

jreback commented Jan 5, 2019

great!

@jreback jreback added the Build Library building on various platforms label Jan 5, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 5, 2019
@jreback
Copy link
Contributor

jreback commented Jan 5, 2019

were you able to build the wheels on a fork to test?

@robbuckley
Copy link
Contributor Author

yes, although its getting difficult as the mac builds on the wheel builder are starting to hit the travis job timeout (50min)

@jreback
Copy link
Contributor

jreback commented Jan 5, 2019

great @robbuckley yeah I think the timeouts are separate (I pushed a fix to see)

@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #24644 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24644   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files         166      166           
  Lines       52379    52379           
=======================================
  Hits        48386    48386           
  Misses       3993     3993
Flag Coverage Δ
#multiple 90.8% <ø> (ø) ⬆️
#single 43.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d106e99...b390c4c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #24644 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24644   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files         166      166           
  Lines       52379    52379           
=======================================
  Hits        48386    48386           
  Misses       3993     3993
Flag Coverage Δ
#multiple 90.8% <ø> (ø) ⬆️
#single 43.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d106e99...b390c4c. Read the comment docs.

@jreback jreback merged commit 6e22000 into pandas-dev:master Jan 5, 2019
@jreback
Copy link
Contributor

jreback commented Jan 5, 2019

thanks @robbuckley

@jreback
Copy link
Contributor

jreback commented Jan 5, 2019

btw I put in place pytest-xdist on the wheels, so finish in about 40 min now :>

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants