-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: 32-bit warning #24588
DOC: 32-bit warning #24588
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24588 +/- ##
=======================================
Coverage 92.36% 92.36%
=======================================
Files 166 166
Lines 52497 52497
=======================================
Hits 48489 48489
Misses 4008 4008
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24588 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 166 166
Lines 52490 52490
=======================================
Hits 48493 48493
Misses 3997 3997
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropping 32-bit support, was this already discussed somewhere recently? (the linked issue seems to be mainly older comments)
Co-Authored-By: jreback <jeff@reback.net>
I am just linking for posterity. |
I understand, but that means we decided to drop 32-bit support for 0.25.0 ? |
that's the issue, this was long ago discussed. I see no reasont keep this burden (and actually the doc note is just to say we are going to do it). |
There was some discussion of finding out usage stats for 32bit python on windows. Did anything come of that? |
For conda downloads, Linux and Mac 32-bit downloads are negligible
(Anaconda Distribution dropped Mac 32 and will drop 32-bit Linux this year).
For windows, the split is 94% to 6% for 64-bit to 32-bit.
…On Thu, Jan 3, 2019 at 11:30 AM jbrockmendel ***@***.***> wrote:
There was some discussion of finding out usage stats for 32bit python on
windows. Did anything come of that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24588 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIn1DZCQbzYz2enytF-SkQgy4K8iyks5u_j4egaJpZM4Zn_So>
.
|
thanks @TomAugspurger yeah main motivation is that we don't have great testing, its just daily and hard to repro / fix. |
We do test on 32-bit windows, right? So perhaps drop support for 32-bit
linux?
…On Thu, Jan 3, 2019 at 12:48 PM Jeff Reback ***@***.***> wrote:
thanks @TomAugspurger <https://github.com/TomAugspurger> yeah main
motivation is that we don't have great testing, its just daily and hard to
repro / fix.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24588 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHInxjqD_ceXsWNp4K0NACtE85MOJxks5u_lCTgaJpZM4Zn_So>
.
|
no we only test on 64-bit windows |
in fact we only here about 32-bit windows at release time I think (when wheels are built) |
any objections? |
@jreback can you raise this again in the original issue (#15889), and give people that participated there some time to respond? (@TomAugspurger can you repeat those numbers there?) |
@jreback I already applied the part of this commit about the py27 warning to master and merged master in your branch. So now this is only about 32bit. |
xref #15889