CLN: Follow-ups to #24024 #24573
Merged
CLN: Follow-ups to #24024 #24573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
commented
Jan 2, 2019
jbrockmendel
commented
Jan 2, 2019
| @@ -3082,7 +3082,7 @@ def _box_item_values(self, key, values): | |||
| def _maybe_cache_changed(self, item, value): | |||
| """The object has called back to us saying maybe it has changed. | |||
| """ | |||
| self._data.set(item, value, check=False) | |||
There was a problem hiding this comment.
check is never True, removed the corresponding code in internals.managers and internals.blocks
jbrockmendel
commented
Jan 2, 2019
| method.__name__ = name | ||
| # TODO: docstrings | ||
| method.__name__ = array_method.__name__ | ||
| method.__doc__ = array_method.__doc__ |
There was a problem hiding this comment.
this should address @jorisvandenbossche's point that docstrings are lost in the existing implementation
Codecov Report
@@ Coverage Diff @@
## master #24573 +/- ##
===========================================
- Coverage 92.31% 43.06% -49.26%
===========================================
Files 166 166
Lines 52556 52526 -30
===========================================
- Hits 48518 22619 -25899
- Misses 4038 29907 +25869
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24573 +/- ##
==========================================
+ Coverage 92.31% 92.32% +0.01%
==========================================
Files 166 166
Lines 52556 52524 -32
==========================================
- Hits 48518 48494 -24
+ Misses 4038 4030 -8
Continue to review full report at Codecov.
|
|
lgtm. |
|
great. after this will be a missing-test pass |
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grepped for TODO in the affected files and took care of the easy ones.
Addresses a flake8 complaint in MultiIndex (no idea why it is only showing up locally)