Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering Methods portions of #24024 #24392

Merged
merged 5 commits into from
Dec 23, 2018
Merged

Conversation

jbrockmendel
Copy link
Member

Uses Substitution for the strftime docstring instead of pinning it below the method.

Changes section titles from "Formatting" to "Rendering Methods" to match other classes.

This is a pre-requisite to another push I'm making to split less-trivial pieces off of #24024, figured it was a decent small-scope to get out of the way.

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Dec 22, 2018

Codecov Report

Merging #24392 into master will decrease coverage by 0.01%.
The diff coverage is 58.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24392      +/-   ##
==========================================
- Coverage    92.3%   92.29%   -0.02%     
==========================================
  Files         162      162              
  Lines       51875    51884       +9     
==========================================
+ Hits        47883    47885       +2     
- Misses       3992     3999       +7
Flag Coverage Δ
#multiple 90.7% <58.82%> (-0.02%) ⬇️
#single 42.99% <47.05%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/period.py 98.49% <100%> (-0.01%) ⬇️
pandas/core/arrays/datetimes.py 97.73% <25%> (-0.52%) ⬇️
pandas/core/arrays/timedeltas.py 86.63% <40%> (-0.53%) ⬇️
pandas/core/arrays/datetimelike.py 96.31% <85.71%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c58817...b355220. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 22, 2018

Codecov Report

Merging #24392 into master will decrease coverage by 0.01%.
The diff coverage is 58.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24392      +/-   ##
==========================================
- Coverage    92.3%   92.29%   -0.02%     
==========================================
  Files         162      162              
  Lines       51875    51884       +9     
==========================================
+ Hits        47883    47885       +2     
- Misses       3992     3999       +7
Flag Coverage Δ
#multiple 90.7% <58.82%> (-0.02%) ⬇️
#single 42.99% <47.05%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/period.py 98.49% <100%> (-0.01%) ⬇️
pandas/core/arrays/datetimes.py 97.73% <25%> (-0.52%) ⬇️
pandas/core/arrays/timedeltas.py 86.63% <40%> (-0.53%) ⬇️
pandas/core/arrays/datetimelike.py 96.31% <85.71%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c58817...b355220. Read the comment docs.

@gfyoung gfyoung added Refactor Internal refactoring of code Docs labels Dec 23, 2018
@jreback jreback added this to the 0.24.0 milestone Dec 23, 2018
@jreback jreback merged commit 759a010 into pandas-dev:master Dec 23, 2018
@jreback
Copy link
Contributor

jreback commented Dec 23, 2018

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the render branch December 23, 2018 16:39
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants