Skip to content

standardize signature for Index reductions, implement nanmean for datetime64 dtypes #24293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Dec 29, 2018
Merged

standardize signature for Index reductions, implement nanmean for datetime64 dtypes #24293

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
f38ffe1
standardize signature for Index reductions, implement nanmean for dat…
jbrockmendel Dec 15, 2018
04cf1f7
suppress warnings
jbrockmendel Dec 15, 2018
3efab79
requested edits
jbrockmendel Dec 15, 2018
a652439
implement view
jbrockmendel Dec 15, 2018
ce760d3
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Dec 19, 2018
2380af6
pass skipna, tests
jbrockmendel Dec 19, 2018
4157f0b
fixup isort
jbrockmendel Dec 20, 2018
50642ae
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Dec 23, 2018
0baedf3
fixup rebase screwups
jbrockmendel Dec 23, 2018
6e0e69f
move len-self checks
jbrockmendel Dec 23, 2018
e2c301b
fixup more rebase screwups
jbrockmendel Dec 23, 2018
fce67ac
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Dec 24, 2018
4b4979f
do values viewing in one place
jbrockmendel Dec 24, 2018
82b8cdf
unpack Series
jbrockmendel Dec 27, 2018
ffe6ada
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Dec 27, 2018
7f7693f
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Dec 28, 2018
07c3102
implement _extract_datetimelike_values_and_dtype
jbrockmendel Dec 28, 2018
6c93410
fix mask
jbrockmendel Dec 28, 2018
4620c56
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Dec 28, 2018
4777b75
requested docstring edits, remoe duplicated view
jbrockmendel Dec 28, 2018
aa4028a
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Dec 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup more rebase screwups
  • Loading branch information
@jbrockmendel
jbrockmendel committed Dec 23, 2018
commit e2c301be95d0b2b04e56ca657f594aa942016e16
4 changes: 2 additions & 2 deletions pandas/tests/reductions/test_reductions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,8 +599,8 @@ def test_minmax_nat_series(self, nat_ser):
# GH#23282
assert nat_ser.min() is pd.NaT
assert nat_ser.max() is pd.NaT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can parameterize over skipna in a lot of the code you added to tests

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just implemented test_reductions, still need to move over the reduction tests from tests.indexes and tests.frames. After they're all in one place is when to really focus on parametrization.

assert nat.min(skipna=False) is pd.NaT
assert nat.max(skipna=False) is pd.NaT
assert nat_ser.min(skipna=False) is pd.NaT
assert nat_ser.max(skipna=False) is pd.NaT

@pytest.mark.parametrize('nat_df', [
pd.DataFrame([pd.NaT, pd.NaT]),
Expand Down