-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: remove failing line #24092
Merged
+73
−38
Merged
CI: remove failing line #24092
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a0a37cc
CI: remove failing line
TomAugspurger 1f15d10
CI: ASV fixups
TomAugspurger e79d52e
debug boto
TomAugspurger 1d0a775
No isorting benchmarks
TomAugspurger d3df86f
correct dtype
TomAugspurger 378515a
more hacky workarounds
TomAugspurger 092320a
Remove unused import
TomAugspurger e20850e
fix skip
TomAugspurger ce0e25c
try marking single...
TomAugspurger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,6 @@ | |
|
||
from __future__ import print_function | ||
|
||
from distutils.version import LooseVersion | ||
from textwrap import dedent | ||
|
||
from pandas.compat import OrderedDict, lzip, map, range, u, unichr, zip | ||
|
@@ -161,15 +160,7 @@ def write_result(self, buf): | |
_classes.extend(self.classes) | ||
|
||
if self.notebook: | ||
div_style = '' | ||
try: | ||
import IPython | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
if IPython.__version__ < LooseVersion('3.0.0'): | ||
div_style = ' style="max-width:1500px;overflow:auto;"' | ||
except (ImportError, AttributeError): | ||
pass | ||
|
||
self.write('<div{style}>'.format(style=div_style)) | ||
self.write('<div>') | ||
|
||
self.write_style() | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,6 +37,11 @@ def s3_resource(tips_file, jsonl_file): | |
""" | ||
pytest.importorskip('s3fs') | ||
boto3 = pytest.importorskip('boto3') | ||
# GH-24092. See if boto.plugin skips the test or fails. | ||
try: | ||
pytest.importorskip("boto.plugin") | ||
except AttributeError: | ||
raise pytest.skip("moto/moto error") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. wow, that is indeed nasty, haha. |
||
moto = pytest.importorskip('moto') | ||
|
||
test_s3_files = [ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is OK to do...
_sparse_series_to_coo
is the only caller, and it uses_get_level_number(x)
to go from maybe labels to numbers.