REF: prelim for fixing array_to_datetime #24000
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tslib.array_to_datetime
has an unusedformat
kwarg. This gets rid of it.to_datetime
(or more specifically,_convert_listlike_datetimes
) has a bunch of boxing logic inside a try/except that doesn't need to be, obscures what Exception we're trying to catch. This moves that code outside the try/except and de-indents it. This overlaps with #23675.xref #23722 (the conversation there less than the OP) cc @mroeschke