Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: prelim for fixing array_to_datetime #24000

Merged
merged 2 commits into from
Nov 29, 2018

Conversation

jbrockmendel
Copy link
Member

tslib.array_to_datetime has an unused format kwarg. This gets rid of it.

to_datetime (or more specifically, _convert_listlike_datetimes) has a bunch of boxing logic inside a try/except that doesn't need to be, obscures what Exception we're trying to catch. This moves that code outside the try/except and de-indents it. This overlaps with #23675.

xref #23722 (the conversation there less than the OP) cc @mroeschke

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Nov 29, 2018

Codecov Report

Merging #24000 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24000      +/-   ##
==========================================
+ Coverage    92.3%    92.3%   +<.01%     
==========================================
  Files         161      161              
  Lines       51555    51557       +2     
==========================================
+ Hits        47589    47591       +2     
  Misses       3966     3966
Flag Coverage Δ
#multiple 90.7% <100%> (ø) ⬆️
#single 42.44% <50%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/tools/datetimes.py 85.53% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7653a6b...03e9ea8. Read the comment docs.

@jreback jreback added Datetime Datetime data dtype Clean labels Nov 29, 2018
@jreback jreback added this to the 0.24.0 milestone Nov 29, 2018
@jreback jreback merged commit 87c6433 into pandas-dev:master Nov 29, 2018
@jreback
Copy link
Contributor

jreback commented Nov 29, 2018

thanks

@jbrockmendel jbrockmendel deleted the a2d-pre1 branch November 29, 2018 22:29
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Datetime Datetime data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants