Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: isort imports - io dir #23332

Merged
merged 1 commit into from
Oct 25, 2018
Merged

CLN: isort imports - io dir #23332

merged 1 commit into from
Oct 25, 2018

Conversation

alimcmaster1
Copy link
Member

@alimcmaster1 alimcmaster1 commented Oct 25, 2018 •
edited by jreback
Loading

Signed-off-by: alimcmaster1 alimcmaster1@gmail.com

Files in pandas/io/* ( 1 of 2)

@alimcmaster1
isort imports-io
a9adff3 
Signed-off-by: alimcmaster1 <alimcmaster1@gmail.com>
@pep8speaks
Copy link

Hello @alimcmaster1! Thanks for submitting the PR.

@WillAyd WillAyd added the Clean label Oct 25, 2018
WillAyd
WillAyd approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if green

WillAyd
WillAyd reviewed Oct 25, 2018
View reviewed changes
setup.cfg
pandas/io/clipboards.py,
pandas/io/excel.py,
pandas/io/date_converters.py,
pandas/io/testing.py,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess as an extra callout this isn't in the diff, though I also don't see it existing as a module

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot - my apologies I don't think this file ever existed in pandas running git log --full-history -- *pandas/io/testing.py confirms this. I think I had a local file named this at one stage and it must have been present when I created the list of files to ignore.

@codecov
Copy link

codecov bot commented Oct 25, 2018 •
edited
Loading

Codecov Report

Merging #23332 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23332   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files         169      169           
  Lines       50924    50924           
=======================================
  Hits        46968    46968           
  Misses       3956     3956
Flag Coverage Δ
#multiple 90.65% <100%> (ø) ⬆️
#single 42.28% <92.15%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/s3.py 86.36% <ø> (ø) ⬆️
pandas/io/feather_format.py 77.14% <100%> (ø) ⬆️
pandas/io/api.py 100% <100%> (ø) ⬆️
pandas/io/date_converters.py 100% <100%> (ø) ⬆️
pandas/io/sas/sas_xport.py 90.23% <100%> (ø) ⬆️
pandas/io/html.py 91.22% <100%> (-0.03%) ⬇️
pandas/io/clipboards.py 100% <100%> (ø) ⬆️
pandas/io/parquet.py 73.72% <100%> (ø) ⬆️
pandas/io/parsers.py 95.6% <100%> (ø) ⬆️
pandas/io/common.py 70.76% <100%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a2d501...a9adff3. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Oct 25, 2018
@jreback jreback merged commit aed5689 into pandas-dev:master Oct 25, 2018
@jreback
Copy link
Contributor

jreback commented Oct 26, 2018

thanks @alimcmaster1

btw in the PR header, use xref issue number (and not closes) other GH will actually close the issue (IOW it doesn't understand partial)

thoo added a commit to thoo/pandas that referenced this pull request Oct 27, 2018
@thoo
Merge remote-tracking branch 'repo_org/master' into Warning_prefix_pa…
cc5dc0f 
…ndas

* repo_org/master: (23 commits)
  DOC: Add docstring validations for "See Also" section (pandas-dev#23143)
  TST: Fix test assertion (pandas-dev#23357)
  BUG: Handle Period in combine (pandas-dev#23350)
  REF: SparseArray imports (pandas-dev#23329)
  CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992)
  DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051)
  Partialy fix issue pandas-dev#23334 - isort pandas/core/groupby directory (pandas-dev#23341)
  TST: Add base test for extensionarray setitem pandas-dev#23300 (pandas-dev#23304)
  API: Add sparse Acessor (pandas-dev#23183)
  PERF: speed up CategoricalIndex.get_loc (pandas-dev#23235)
  fix and test incorrect case in delta_to_nanoseconds (pandas-dev#23302)
  BUG: Handle Datetimelike data in DataFrame.combine (pandas-dev#23317)
  TST: re-enable gbq tests (pandas-dev#23303)
  Switched references of App veyor to azure pipelines in the contributing CI section (pandas-dev#23311)
  isort imports-io (pandas-dev#23332)
  DOC: Added a Multi Index example for the Series.sum method (pandas-dev#23279)
  REF: Make PeriodArray an ExtensionArray (pandas-dev#22862)
  DOC: Added Examples for Series max (pandas-dev#23298)
  API/ENH: tz_localize handling of nonexistent times: rename keyword + add shift option (pandas-dev#22644)
  BUG: Let MultiIndex.set_levels accept any iterable (pandas-dev#23273) (pandas-dev#23291)
  ...
thoo added a commit to thoo/pandas that referenced this pull request Oct 27, 2018
@thoo
Merge remote-tracking branch 'repo_org/master' into check_np_pd_fromE…
881b011 
…xamples

* repo_org/master: (83 commits)
  DOC: Add docstring validations for "See Also" section (pandas-dev#23143)
  TST: Fix test assertion (pandas-dev#23357)
  BUG: Handle Period in combine (pandas-dev#23350)
  REF: SparseArray imports (pandas-dev#23329)
  CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992)
  DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051)
  Partialy fix issue pandas-dev#23334 - isort pandas/core/groupby directory (pandas-dev#23341)
  TST: Add base test for extensionarray setitem pandas-dev#23300 (pandas-dev#23304)
  API: Add sparse Acessor (pandas-dev#23183)
  PERF: speed up CategoricalIndex.get_loc (pandas-dev#23235)
  fix and test incorrect case in delta_to_nanoseconds (pandas-dev#23302)
  BUG: Handle Datetimelike data in DataFrame.combine (pandas-dev#23317)
  TST: re-enable gbq tests (pandas-dev#23303)
  Switched references of App veyor to azure pipelines in the contributing CI section (pandas-dev#23311)
  isort imports-io (pandas-dev#23332)
  DOC: Added a Multi Index example for the Series.sum method (pandas-dev#23279)
  REF: Make PeriodArray an ExtensionArray (pandas-dev#22862)
  DOC: Added Examples for Series max (pandas-dev#23298)
  API/ENH: tz_localize handling of nonexistent times: rename keyword + add shift option (pandas-dev#22644)
  BUG: Let MultiIndex.set_levels accept any iterable (pandas-dev#23273) (pandas-dev#23291)
  ...
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@alimcmaster1 @tm9k1
isort imports-io (pandas-dev#23332)
64e31ca 
Signed-off-by: alimcmaster1 <alimcmaster1@gmail.com>
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@alimcmaster1 @Pingviinituutti
isort imports-io (pandas-dev#23332)
292444a 
Signed-off-by: alimcmaster1 <alimcmaster1@gmail.com>
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@alimcmaster1 @Pingviinituutti
isort imports-io (pandas-dev#23332)
06f9354 
Signed-off-by: alimcmaster1 <alimcmaster1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@alimcmaster1 @pep8speaks @jreback @WillAyd