Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Series ndarray properties (strides, data, base, itemsize, flags) #20721

Merged
merged 10 commits into from
Apr 25, 2018
Merged

DEPR: Series ndarray properties (strides, data, base, itemsize, flags) #20721

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c3ac291
DEPR: Series ndarray properties (strides, data, base, itemsize, flags)
jorisvandenbossche Apr 17, 2018
11182b1
better warning message
jorisvandenbossche Apr 18, 2018
1aeaf2e
add whatsnew
jorisvandenbossche Apr 18, 2018
5339975
fix usage in tests
jorisvandenbossche Apr 18, 2018
c78d5d6
fix remaining tests
jorisvandenbossche Apr 19, 2018
5bd2940
Merge remote-tracking branch 'upstream/master' into depr-series-ndarr…
jorisvandenbossche Apr 23, 2018
160ace0
also deprecate DatetimeIndex.base
jorisvandenbossche Apr 23, 2018
d2088d2
array -> asarray
jorisvandenbossche Apr 23, 2018
7687330
fix usage of base in DatetimeIndexConstructor (_deepcopy_if_needed)
jorisvandenbossche Apr 24, 2018
feb7caf
fix usage of .base in BlockManager test_copy
jorisvandenbossche Apr 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix remaining tests
  • Loading branch information
@jorisvandenbossche
jorisvandenbossche committed Apr 19, 2018
commit c78d5d698623fbd758767a2a2dc18ac8f96e2336
2 changes: 2 additions & 0 deletions pandas/core/algorithms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1491,6 +1491,8 @@ def take_nd(arr, indexer, axis=0, out=None, fill_value=np.nan, mask_info=None,
if is_sparse(arr):
arr = arr.get_values()

arr = np.array(arr, copy=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np.asarray slightly more idiomatic

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes (for some reason I wanted the copy=False keyword, but for asarray that is of course just the default behaviour)


if indexer is None:
indexer = np.arange(arr.shape[axis], dtype=np.int64)
dtype, fill_value = arr.dtype, arr.dtype.type()
Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/indexes/test_multi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

class TestMultiIndex(Base):
_holder = MultiIndex
_compat_props = ['shape', 'ndim', 'size', 'itemsize']
_compat_props = ['shape', 'ndim', 'size']

def setup_method(self, method):
major_axis = Index(['foo', 'bar', 'baz', 'qux'])
Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/indexes/test_range.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

class TestRangeIndex(Numeric):
_holder = RangeIndex
_compat_props = ['shape', 'ndim', 'size', 'itemsize']
_compat_props = ['shape', 'ndim', 'size']

def setup_method(self, method):
self.indices = dict(index=RangeIndex(0, 20, 2, name='foo'),
Expand Down