Skip to content

Performance increase rolling min max #19549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Feb 14, 2018
Merged

Performance increase rolling min max #19549

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
737c033
First stab at using deque over full iterations
hexgnu Feb 6, 2018
15d2563
Working deque implementation of min/max
hexgnu Feb 6, 2018
06f2658
oops
hexgnu Feb 6, 2018
8089e67
Remove some extraneous variables
hexgnu Feb 6, 2018
08ff553
Get rid of some of the branches in the code
hexgnu Feb 6, 2018
6ef87b2
Revert "Get rid of some of the branches in the code"
hexgnu Feb 6, 2018
6e8c041
Prefer cmath over math.h for cpp
hexgnu Feb 7, 2018
b0a0ef6
Change to std namespace
hexgnu Feb 7, 2018
b19774e
Fix issue with variable window size
hexgnu Feb 7, 2018
92857ee
Oh right variable window size ;)
hexgnu Feb 7, 2018
832ff9d
Use std namespace for windows compilation
hexgnu Feb 7, 2018
f00e994
Add cmath so build will complete
hexgnu Feb 7, 2018
0d713be
Merge remote-tracking branch 'upstream/master' into performance_incre…
hexgnu Feb 8, 2018
1ab4e21
Fix linting error in window.pyx
hexgnu Feb 8, 2018
d5b60cd
I think this will fix MSVC build
hexgnu Feb 8, 2018
42f8fdf
I think this is what I want to do
hexgnu Feb 8, 2018
38e3f70
Add documentation
hexgnu Feb 9, 2018
7f4abf9
Add another benchmark to test variable window methods
hexgnu Feb 9, 2018
23fe816
Ugh use // not #
hexgnu Feb 9, 2018
060dfb7
New better benchmark
hexgnu Feb 9, 2018
aeb9b9b
Add whatsnew entry
hexgnu Feb 12, 2018
65c0dbe
Merge remote-tracking branch 'upstream/master' into performance_incre…
hexgnu Feb 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change to std namespace
  • Loading branch information
@hexgnu
hexgnu committed Feb 7, 2018
commit b0a0ef63185935997201d5ecc253d1d0df775abd
2 changes: 1 addition & 1 deletion pandas/_libs/window.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ from numpy cimport ndarray, double_t, int64_t, float64_t
cnp.import_array()


cdef extern from "../src/headers/math.h":
cdef extern from "../src/headers/math.h" namespace "std":
int signbit(double) nogil
double sqrt(double x) nogil

Expand Down