CLN: ASV io benchmarks #18906
Merged
CLN: ASV io benchmarks #18906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18906 +/- ##
==========================================
- Coverage 91.65% 91.59% -0.06%
==========================================
Files 154 150 -4
Lines 51368 48939 -2429
==========================================
- Hits 47080 44826 -2254
+ Misses 4288 4113 -175
Continue to review full report at Codecov.
|
asv_bench/benchmarks/io/sql.py
Outdated
| read_sql_query(self.query_all, self.con) | ||
|
|
||
| def time_read_sql_query_select_column(self, connection, dtype): | ||
| read_sql_query(self.query_all, self.con) |
asv_bench/benchmarks/io/sql.py
Outdated
|
|
||
| goal_time = 0.2 | ||
| params = (['sqlalchemy', 'sqlite'], | ||
| ['float', 'float_with_nan', 'string', 'bool', 'int', 'datetime']) |
There was a problem hiding this comment.
I would personally keep this benchmark splitted into two classes where one has those params (for testing types) and the other not. As now this creates a lot of extra benchmarks that are not needed
|
Fixed the incorrect benchmark and split up the SQL benchmark to avoid redundant tests. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref
Consolidated the benchmarks from
io_sql.py,hdfstore_bench.py, andpackers.pyinto their own files in theiofolder. Benchmarks are largely the same as they were, just cleaned and simplified where able.