Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: ASV replace #18833

Merged
merged 2 commits into from
Dec 21, 2017
Merged

CLN: ASV replace #18833

merged 2 commits into from
Dec 21, 2017

Conversation

mroeschke
Copy link
Member

  • Flake8'd and removed star imports

For the ReplaceDict benchmark I reduced the number of samples from 10^6 to 10^5 because it was taking a significant amount of time, but 10^5 samples should still be representative of a large sample performance.

asv dev -b ^replace
· Discovering benchmarks
· Running 4 total benchmarks (1 commits * 1 environments * 4 benchmarks)
[  0.00%] ·· Building for existing-py_home_matt_anaconda_envs_pandas_dev_bin_python
[  0.00%] ·· Benchmarking existing-py_home_matt_anaconda_envs_pandas_dev_bin_python
[ 25.00%] ··· Running replace.Convert.time_replace                                                               ok
[ 25.00%] ···· 
               ============ =========== ===========
               --                 replace_data     
               ------------ -----------------------
                contructor   Timestamp   Timedelta 
               ============ =========== ===========
                DataFrame      411ms       409ms   
                  Series       349ms       349ms   
               ============ =========== ===========

[ 50.00%] ··· Running replace.NaN.time_fillna                                                                    ok
[ 50.00%] ···· 
               ========= ========
                inplace          
               --------- --------
                  True    6.42ms 
                 False    15.0ms 
               ========= ========

[ 75.00%] ··· Running replace.NaN.time_replace                                                                   ok
[ 75.00%] ···· 
               ========= ========
                inplace          
               --------- --------
                  True    7.09ms 
                 False    23.6ms 
               ========= ========

[100.00%] ··· Running replace.ReplaceDict.time_replace_series                                                    ok
[100.00%] ···· 
               ========= =======
                inplace         
               --------- -------
                  True    7.43s 
                 False    7.48s 
               ========= =======

@codecov
Copy link

codecov bot commented Dec 19, 2017

Codecov Report

Merging #18833 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18833      +/-   ##
==========================================
- Coverage   91.64%   91.62%   -0.02%     
==========================================
  Files         154      154              
  Lines       51408    51408              
==========================================
- Hits        47113    47104       -9     
- Misses       4295     4304       +9
Flag Coverage Δ
#multiple 89.49% <ø> (ø) ⬆️
#single 40.83% <ø> (-0.12%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.68% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6a7cc9...5b97df9. Read the comment docs.

@jreback jreback added the Benchmark Performance (ASV) benchmarks label Dec 19, 2017

def time_replace_fillna(self):
self.ts.fillna(0.0, inplace=True)
class NaN(object):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you give this class a more informative name, maybe FillNA?

@mroeschke
Copy link
Member Author

Changed the class name from NaN to Fillna

@jreback jreback added this to the 0.23.0 milestone Dec 21, 2017
@jreback jreback merged commit c2ea258 into pandas-dev:master Dec 21, 2017
@jreback
Copy link
Contributor

jreback commented Dec 21, 2017

thanks @mroeschke

@mroeschke mroeschke deleted the asv_clean_replace branch December 21, 2017 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants