CLN: ASV inference benchmark #18759
Merged
CLN: ASV inference benchmark #18759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18759 +/- ##
==========================================
- Coverage 91.61% 91.59% -0.03%
==========================================
Files 153 153
Lines 51363 51363
==========================================
- Hits 47058 47047 -11
- Misses 4305 4316 +11
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18759 +/- ##
==========================================
+ Coverage 91.61% 91.61% +<.01%
==========================================
Files 153 154 +1
Lines 51363 51430 +67
==========================================
+ Hits 47058 47120 +62
- Misses 4305 4310 +5
Continue to review full report at Codecov.
|
jreback
requested changes
Dec 13, 2017
asv_bench/benchmarks/inference.py
Outdated
| import pandas as pd | ||
| import numpy as np | ||
| import pandas.util.testing as tm | ||
| import pandas._libs.lib as lib |
There was a problem hiding this comment.
so this is not backward compat before 0.20., but I think ok for now.
There was a problem hiding this comment.
Do you recall what this import would be pre 0.20?
There was a problem hiding this comment.
from pandas import lib (this is in fact what pandas/lib.py does now, but that will get blown away in 0.22
There was a problem hiding this comment.
You can import lib from pandas_vb_common.py, the back compat is handled there
asv_bench/benchmarks/inference.py
Outdated
| # from GH 7332 | ||
| goal_time = 0.2 | ||
| params = ['int64', 'int32', 'uint32', 'float32', 'float64'] |
There was a problem hiding this comment.
add uint64. you can add int16, int8, uint16, uint8 as well to cover the bases
There was a problem hiding this comment.
we may want to define these numeric dtypes elsewhere and import here (so we are consistent across the asv),
and prob for datetimelike as well
asv_bench/benchmarks/inference.py
Outdated
|
|
||
| param_names = ['dtype', 'downcast'] | ||
| params = [['string-float', 'string-int', 'string-nint', 'datetime64', | ||
| 'int-list', 'int32'], | ||
| [None, 'integer', 'signed', 'unsigned', 'float']] | ||
|
|
||
| N = 500000 | ||
| N2 = int(N / 2) |
There was a problem hiding this comment.
this was for a good reason, you can't use floats to multiply lists (I find it a bit strange that this didn't fail for you)
|
Created a new |
asv_bench/benchmarks/inference.py
Outdated
| try: | ||
| import pandas._libs.lib as lib | ||
| except ImportError: | ||
| import pandas.lib as lib |
There was a problem hiding this comment.
I would keep this in pandas_vb_common, you can just import lib from there (as this can then be reused in multiple files)
|
@jorisvandenbossche changed the |
jreback
approved these changes
Dec 18, 2017
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flake8 and removed star imports
Used
paramsandsetup_cachewhere possible