Skip to content

Rename signature fix #17966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 27, 2017
Prev Previous commit
Next Next commit
For panel4d
  • Loading branch information
TomAugspurger committed Oct 24, 2017
commit fbf246bbb8a8403833cd6e94f36861f83be52fcd
33 changes: 28 additions & 5 deletions pandas/core/panel4d.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
""" Panel4D: a 4-d dict like collection of panels """

import warnings
from pandas.core.generic import NDFrame
from pandas.core.panelnd import create_nd_panel_factory
from pandas.core.panel import Panel

Expand Down Expand Up @@ -62,12 +63,34 @@ def panel4d_reindex(self, labs=None, labels=None, items=None, major_axis=None,
# Hack for reindex_axis deprecation
# Ha, we used labels for two different things
# I think this will work still.
axes = self._validate_axis_style_args(
labs, 'labels',
axes=[labels, items, major_axis, minor_axis],
axis=axis, method_name='reindex')
if labs is None:
args = ()
else:
args = (labs,)
kwargs_ = dict(labels=labels,
items=items,
major_axis=major_axis,
minor_axis=minor_axis,
axis=axis)
kwargs_ = {k: v for k, v in kwargs_.items() if v is not None}
# major = kwargs.pop("major", None)
# minor = kwargs.pop('minor', None)

# if major is not None:
# if kwargs.get("major_axis"):
# raise TypeError("Cannot specify both 'major' and 'major_axis'")
# kwargs_['major_axis'] = major
# if minor is not None:
# if kwargs.get("minor_axis"):
# raise TypeError("Cannot specify both 'minor' and 'minor_axis'")
# kwargs_['minor_axis'] = minor

if axis is not None:
kwargs_['axis'] = axis

axes = self._validate_axis_style_args(args, kwargs_, 'labs', 'reindex')
kwargs.update(axes)
return super(Panel, self).reindex(**kwargs)
return NDFrame.reindex(self, **kwargs)


Panel4D.__init__ = panel4d_init
Expand Down