-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: sub-section on boolean Index array changes #17803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17803 +/- ##
==========================================
- Coverage 91.24% 91.22% -0.02%
==========================================
Files 163 163
Lines 49971 49971
==========================================
- Hits 45597 45588 -9
- Misses 4374 4383 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #17803 +/- ##
==========================================
- Coverage 91.25% 91.23% -0.03%
==========================================
Files 163 163
Lines 49971 49971
==========================================
- Hits 45599 45589 -10
- Misses 4372 4382 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I would also add that previously for non-boolean and non-numeric indices, it would raise a KeyError (since the True / False were regarded as labels), and not will do boolean selection.
not following, what is the example? |
So previously Index with True / False values were always regarded as labels, not as a boolean mask. Which resulted in a KeyError for non-numeric indices or actual label-based indexing for numeric/boolean index (the fact that it interpreted True/False as 1/0 is the bug that was been fixed in an earlier PR regarding drop, but the general thing (your recent PR) that boolean index is not seen as labels is the API change you describe in the PR here). So previous:
Now:
|
(but it is not perse necessary to add all those example, for me just adding it in the text is fine as well. I suspect that not many people deliberately will have used a boolean index to index a non-numeric index and explicitly catched the KeyError ... The main change is when you actually had a boolean index in the object you are indexing (i.e. the case for which you already have an example)) |
ic, ok will add that as well. |
closes #17740