Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: overflow on Timedelta construction & arithmetic now raises #17640

Merged
merged 1 commit into from
Sep 23, 2017
Merged

BUG: overflow on Timedelta construction & arithmetic now raises #17640

merged 1 commit into from
Sep 23, 2017

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Sep 23, 2017 •
edited
Loading

closes #17637

@jreback jreback added Compat pandas objects compatability with Numpy or Python functions Timedelta Timedelta data type labels Sep 23, 2017
@jreback jreback added this to the 0.21.0 milestone Sep 23, 2017
@codecov
Copy link

codecov bot commented Sep 23, 2017

Codecov Report

Merging #17640 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17640      +/-   ##
==========================================
- Coverage   91.22%    91.2%   -0.02%     
==========================================
  Files         163      163              
  Lines       49655    49655              
==========================================
- Hits        45297    45288       -9     
- Misses       4358     4367       +9
Flag Coverage Δ
#multiple 88.99% <ø> (ø) ⬆️
#single 40.17% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.77% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da93f51...f1b9905. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 23, 2017 •
edited
Loading

Codecov Report

Merging #17640 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17640      +/-   ##
==========================================
- Coverage   91.22%    91.2%   -0.02%     
==========================================
  Files         163      163              
  Lines       49655    49655              
==========================================
- Hits        45297    45288       -9     
- Misses       4358     4367       +9
Flag Coverage Δ
#multiple 88.99% <ø> (ø) ⬆️
#single 40.17% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.77% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da93f51...f1b9905. Read the comment docs.

@jreback jreback merged commit 76d1744 into pandas-dev:master Sep 23, 2017
This was referenced Sep 25, 2017
Closed
Closed
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
@jreback @alanbato
BUG: overflow on Timedelta construction & arithmetic now raises (pand…
581fb42 
…as-dev#17640)

closes pandas-dev#17637
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
@jreback @No-Stream
BUG: overflow on Timedelta construction & arithmetic now raises (pand…
10d0650 
…as-dev#17640)

closes pandas-dev#17637
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions Timedelta Timedelta data type
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.

BUG: overflow in Timedelta arithmetic
1 participant
@jreback