-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: .iloc[:] and .loc[:] return a copy of the original object #13873 #16443
Merged
jreback
merged 13 commits into
pandas-dev:master
from
margaret:identity_slice_return_new_object
Jun 14, 2017
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f8c2202
BUG: .iloc[:] and .loc[:] return copy of original object (#13873)
margaret 84f2d5d
iloc and loc return new object when slice is a tuple
margaret fd47ef0
Revert "iloc and loc return new object when slice is a tuple"
margaret ef0af94
return a shallow copy instead of deep copy
margaret cd4980e
_getitem_lowerdim won't return copy of object if called with [:]
margaret 6771c59
Add item for indexers returning new object instead of original
margaret a405a10
grammar correction - i.e. to e.g.
margaret ad1be5d
fix some spacing and linting errors
margaret c139b47
remove indexer type from test name
margaret 7634d3b
add tests for Series
margaret c78c43c
test that df.loc[:,0] returns a view
margaret 3f33c61
fix linting error
margaret d130824
add tests for direct slicing
margaret File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
BUG: .iloc[:] and .loc[:] return copy of original object (#13873)
This is consistent with the behavior of [:] on a list https://docs.python.org/2/tutorial/introduction.html#lists https://docs.python.org/3/tutorial/introduction.html#lists
- Loading branch information
commit f8c22025d2273e35a0f8d5e3677968b4191eb97c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just rename to
test_identity_slice_returns_new_object
(and same for one in thetest_loc
file