Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup to #20583 (observed keyword for Groupby) #20902

Closed
TomAugspurger opened this issue May 1, 2018 · 0 comments · Fixed by #20941
Closed

Followup to #20583 (observed keyword for Groupby) #20902

TomAugspurger opened this issue May 1, 2018 · 0 comments · Fixed by #20941
Labels
Categorical Categorical Data Type Docs Groupby
Milestone
0.23.0

Comments

@TomAugspurger
Copy link
Contributor

  1. Change Grouping.init default observed to False: API: categorical grouping will no longer return the cartesian product #20583 (comment)
  2. whatsnew description on unobserved, cartesian product: API: categorical grouping will no longer return the cartesian product #20583 (comment)
  3. Simplify implementation? API: categorical grouping will no longer return the cartesian product #20583 (comment)
  4. rst formatting: https://github.com/pandas-dev/pandas/pull/20583/files/bdf7525812ca670f9406ab8df333030d36d30947#diff-03b380f521c43cf003207b0711bac67f
  5. stale comment? API: categorical grouping will no longer return the cartesian product #20583 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Categorical Categorical Data Type Docs Groupby
Projects
None yet
Milestone
0.23.0
Development

Successfully merging a pull request may close this issue.

DOC: followup to #20583, observed kwarg for .groupby jreback/pandas
1 participant
@TomAugspurger