Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMPAT: Standardize method signatures #12662

Closed
gfyoung opened this issue Mar 17, 2016 · 1 comment
Closed

COMPAT: Standardize method signatures #12662

gfyoung opened this issue Mar 17, 2016 · 1 comment
Labels
API Design Compat pandas objects compatability with Numpy or Python functions
Milestone
0.20.0

Comments

@gfyoung
Copy link
Member

gfyoung commented Mar 17, 2016 •
edited
Loading

Currently, the parameter for values that one needs to insert into an array-like object such as DataFrame or Series is inconsistent across implementations. For example, base.py surfaces it as key, whereas series.py surfaces it as v.

This issue was identified while fixing an issue for v0.18.1 (xref #12413), but in the interests of maintaining backwards compatibility for a minor release, this change should be made as early as v0.19.0 with the following API comment:

"The signature for searchsorted has changed. It is now searchsorted(self, value, side='left', sorter=None)."

List of functions with signature inconsistencies:
searchsorted
repeat

@jreback
@jorisvandenbossche
@jreback jreback changed the title Standardize searchsorted API COMPAT: Standardize .searchsorted signature Mar 17, 2016
@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label Mar 17, 2016
@jreback jreback added this to the 0.19.0 milestone Mar 17, 2016
@gfyoung gfyoung changed the title COMPAT: Standardize .searchsorted signature COMPAT: Standardize signatures Apr 6, 2016
@gfyoung gfyoung changed the title COMPAT: Standardize signatures COMPAT: Standardize method signatures Apr 6, 2016
@gfyoung
Copy link
Member Author

gfyoung commented Apr 6, 2016

In my quest to conquer fromnumeric.py incompatibilities, I have come across several other signature inconsistencies that I think also merit addressing. I've updated the original issue to reflect that.

gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 13, 2016
@gfyoung
Standardize function signatures
e529572 
Standardize the following function signatures:

1) repeat(reps, *args, **kwargs)
2) searchsorted(key, side='left', sorter=None)

Closes pandas-devgh-12662.
@gfyoung gfyoung mentioned this issue Nov 13, 2016
Merged
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 13, 2016
@gfyoung
Standardize function signatures
6c59f44 
Standardize the following function signatures:

1) repeat(reps, *args, **kwargs)
2) searchsorted(key, side='left', sorter=None)

Closes pandas-devgh-12662.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 13, 2016
@gfyoung
Standardize function signatures
fdd6fbf 
Standardize the following function signatures:

1) repeat(reps, *args, **kwargs)
2) searchsorted(key, side='left', sorter=None)

Closes pandas-devgh-12662.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 14, 2016
@gfyoung
Standardize function signatures
a29bba6 
Standardize the following function signatures:

1) repeat(reps, *args, **kwargs)
2) searchsorted(key, side='left', sorter=None)

Closes pandas-devgh-12662.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 15, 2016
@gfyoung
Standardize function signatures
d4c23ea 
Standardize the following function signatures:

1) repeat(reps, *args, **kwargs)
2) searchsorted(key, side='left', sorter=None)

Closes pandas-devgh-12662.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 16, 2016
@gfyoung
Standardize function signatures
fdef7a3 
Standardize the following function signatures:

1) repeat(reps, *args, **kwargs)
2) searchsorted(key, side='left', sorter=None)

Closes pandas-devgh-12662.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 17, 2016
@gfyoung
Standardize function signatures
30d2891 
Standardize the following function signatures:

1) repeat(reps, *args, **kwargs)
2) searchsorted(key, side='left', sorter=None)

Closes pandas-devgh-12662.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 18, 2016
@gfyoung
Standardize function signatures
b9618f8 
Standardize the following function signatures:

1) repeat(reps, *args, **kwargs)
2) searchsorted(key, side='left', sorter=None)

Closes pandas-devgh-12662.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 18, 2016
@gfyoung
Standardize function signatures
8ff613b 
Standardize the following function signatures:

1) repeat(reps, *args, **kwargs)
2) searchsorted(key, side='left', sorter=None)

Closes pandas-devgh-12662.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 20, 2016
@gfyoung
Standardize function signatures
11dfa5c 
Standardize the following function signatures:

1) repeat(reps, *args, **kwargs)
2) searchsorted(key, side='left', sorter=None)

Closes pandas-devgh-12662.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 20, 2016
@gfyoung
Standardize function signatures
9f14c49 
Standardize the following function signatures:

1) repeat(reps, *args, **kwargs)
2) searchsorted(key, side='left', sorter=None)

Closes pandas-devgh-12662.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 22, 2016
@gfyoung
Standardize function signatures
c4e0bb8 
Standardize the following function signatures:

1) repeat(reps, *args, **kwargs)
2) searchsorted(key, side='left', sorter=None)

Closes pandas-devgh-12662.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 22, 2016
@gfyoung
Standardize function signatures
26f7be9 
Standardize the following function signatures:

1) repeat(reps, *args, **kwargs)
2) searchsorted(key, side='left', sorter=None)

Closes pandas-devgh-12662.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 23, 2016
@gfyoung
Standardize function signatures
c5059b6 
Standardize the following function signatures:

1) repeat(reps, *args, **kwargs)
2) searchsorted(key, side='left', sorter=None)

Closes pandas-devgh-12662.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 25, 2016
@gfyoung
Standardize function signatures
ec75525 
Standardize the following function signatures:

1) repeat(reps, *args, **kwargs)
2) searchsorted(key, side='left', sorter=None)

Closes pandas-devgh-12662.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 25, 2016
@gfyoung
Standardize function signatures
3d469de 
Standardize the following function signatures:

1) repeat(reps, *args, **kwargs)
2) searchsorted(key, side='left', sorter=None)

Closes pandas-devgh-12662.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 25, 2016
@gfyoung
Standardize function signatures
3cdded5 
Standardize the following function signatures:

1) repeat(reps, *args, **kwargs)
2) searchsorted(key, side='left', sorter=None)

Closes pandas-devgh-12662.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 25, 2016
@gfyoung
Standardize function signatures
f448639 
Standardize the following function signatures:

1) repeat(reps, *args, **kwargs)
2) searchsorted(value, side='left', sorter=None)

Closes pandas-devgh-12662.
jorisvandenbossche pushed a commit that referenced this issue Nov 26, 2016
@gfyoung @jorisvandenbossche
Standardize function signatures (#14645)
08d7b2c 
Standardize the following function signatures:

1) repeat(reps, *args, **kwargs)
2) searchsorted(value, side='left', sorter=None)

Closes gh-12662.
@jsexauer jsexauer mentioned this issue Dec 23, 2016
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Design Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
0.20.0
Development

No branches or pull requests
2 participants
@jreback @gfyoung