Skip to content

improvements #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 22, 2022
Merged

improvements #43

merged 6 commits into from
Jun 22, 2022

Conversation

frangametv
Copy link
Contributor

No description provided.

@pH-7
Copy link
Owner

pH-7 commented Jun 5, 2022

Thanks very much for your contribution @frangametv

Can you describe what your PR does and add some screenshots of the text editor after your changes?

@frangametv
Copy link
Contributor Author

frangametv commented Jun 6, 2022

I moved the "icons" folder inside the .jar and used class resource loading; then i forced the JavaAWT UIManager Style to Windows Modern Look, and this gives a completely new modern look to the text editor.
You have the code, I only changed a few lines and I also recompiled the project into a .jar, you can see the differences by yourself.

Copy link
Owner

@pH-7 pH-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just two minor changes needed to be confirmed/changed.

@pH-7
Copy link
Owner

pH-7 commented Jun 19, 2022

@frangametv With what Java version did you test it?

@frangametv Could you also update the SimpleJavaTextEditor.jar with your version and run it?
You can also generate easily a new jar file with the following command when you are in src/ directory jar cmvf ../manifest.mf ../SimpleJavaTextEditor.jar simplejavatexteditor/*.class

But my branch is updated, i'll use two commits and try to fix this
@frangametv
Copy link
Contributor Author

Java version: From 1.8 to the newest, it worked just fine
I already updated the Jar file, as you can see from the changes.

@frangametv
Copy link
Contributor Author

Sorry for the deleted comment, my bad

@pH-7
Copy link
Owner

pH-7 commented Jun 20, 2022

Java version: From 1.8 to the newest, it worked just fine
I already updated the Jar file, as you can see from the changes.

Beautiful! This sounds brilliant @frangametv! I will check this out this evening.

@frangametv
Copy link
Contributor Author

fixed

@pH-7
Copy link
Owner

pH-7 commented Jun 22, 2022

fixed

This is brilliant! Amazing job!

@pH-7 pH-7 merged commit d80f6a3 into pH-7:master Jun 22, 2022
@pH-7
Copy link
Owner

pH-7 commented Jun 22, 2022

I’ve now merged your changes. Thanks again for your contribution to this project. I really appreciate the improvements you have done to it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants