Code Improved and Bug Fixed #39

TT-talhatariq · 2021-09-07T08:32:53Z

I improved the code readability by changing for loops and switch statements with enhanced for loops and switch statements respectively

Also, there is a bug in the Find.java class. If we replace a word of Text with another one, all the characters who're in Uppercase in NotePad, changed to LowerCase.

pH-7 · 2021-11-03T10:14:01Z

Thanks for this @TT-talhatariq!! Highly appreciated 👏

pH-7 · 2021-11-03T10:14:21Z

@TT-talhatariq Why have you added a bunch of images in bin/? And they don't seem to be used anywhere...

pH-7 · 2021-11-03T10:16:15Z

.idea/.gitignore

@@ -0,0 +1,8 @@
+# Default ignored files


.gitignore in the .idea folder...?

.idea/.name

TT-talhatariq · 2021-11-05T15:03:12Z

Actually, it was because of IntelliJ Idea. Once I opened this project in that IDE, and that IDE created some extra folders and files in it.
Anyways, I resolved these issues.

TT-talhatariq

Review this now.

pH-7 · 2021-11-06T09:07:28Z

Actually, it was because of IntelliJ Idea. Once I opened this project in that IDE, and that IDE created some extra folders and files in it.
Anyways, I resolved these issues.

That looks much cleaner now. Thank you! To avoid that, it could be nice to add .idea to the root .gitignore file then.

pH-7

@TT-talhatariq Why did you remove all toLowerCase ?

pH-7 · 2021-11-06T09:14:15Z

src/simplejavatexteditor/Find.java

@@ -175,7 +175,7 @@ public void replace() {
    }

    public void replaceAll() {
-        txt.setText(txt.getText().toLowerCase().replaceAll(textF.getText().toLowerCase(), textR.getText()));
+        txt.setText(txt.getText().replaceAll(textF.getText() , textR.getText()));


Was there a reason why you removed the case-insensitive selection.toLowerCase?

Because there is a bug in the replaceAll() method of Find.java class. If we replace the word of Text in NotePad with a word, all the characters who're in Uppercase in NotePad, changed to LowerCase.

Like, let's say there is "Talha is Here" in notePad and I replaced the name "Talha" with "Ali" by using the replace all field.
That statement will first change the text of NotePad "Talha is Here" into "talha is ali".

All Uppercase letters are converted into lower case.

You can Test that replaceAll() function.

pH-7 · 2021-11-06T09:19:17Z

@TT-talhatariq With what Java version did you test it?

Could you also update the SimpleJavaTextEditor.jar with your version and run it?
You can also generate easily a new jar file with the following command when you are in src/ directory jar cmvf ../manifest.mf ../SimpleJavaTextEditor.jar simplejavatexteditor/*.class

pH-7 · 2021-11-09T09:53:53Z

@TT-talhatariq Once my concerns have been addressed, I will be happy to approve your work and merge it 😊

TT-talhatariq

I explained replaceAll() bug above in detail. If you have further query let me Know.

Also, I updated the Jar file. And I'm using java version 17.

Now, there's no issue of cases. First It even replaces the word "talha" with "Talha" in notepad and vice-versa. But this is not possible now and also bug of all lowercase letters resolved.

pH-7 · 2021-11-21T05:45:51Z

I explained replaceAll() bug above in detail. If you have further query let me Know.

Also, I updated the Jar file. And I'm using java version 17.

Now, there's no issue of cases. First It even replaces the word "talha" with "Talha" in notepad and vice-versa. But this is not possible now and also bug of all lowercase letters resolved.

Yes, I've seen it now where you mentioned the bug.

Awesome, thanks very much for doing so @TT-talhatariq 😄

pH-7 · 2021-11-21T05:46:57Z

Also, I updated the Jar file. And I'm using java version 17.

Can you replace the current jar file of the project by yours?

pH-7 · 2021-11-21T05:47:25Z

Here :)

In the root directory of the project.

TT-talhatariq · 2021-11-21T13:20:09Z

Also, I updated the Jar file. And I'm using java version 17.

Can you replace the current jar file of the project by yours?

But, I have already replaced my own version of jar file with the jar file of the root directory of this project. Here is the picture of changes in project.

TT-talhatariq · 2021-11-21T13:21:28Z

Yes, I've seen it now where you mentioned the bug.

Awesome, thanks very much for doing so @TT-talhatariq 😄

Thank you for your appreciation 😁

pH-7 · 2021-11-25T08:05:15Z

Also, I updated the Jar file. And I'm using java version 17.

Can you replace the current jar file of the project by yours?

But, I have already replaced my own version of jar file with the jar file of the root directory of this project. Here is the picture of changes in project.

Oh, I see now 🙂 Somehow I missed it 😄 Thank you for your prompt reply @TT-talhatariq! You rock! 👌

Code Improved and Bug Fixed

8848253

pH-7 assigned TT-talhatariq Nov 3, 2021

pH-7 reviewed Nov 3, 2021

View reviewed changes

.idea/.gitignore Outdated

@@ -0,0 +1,8 @@

# Default ignored files

Copy link

Owner

pH-7 Nov 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.gitignore in the .idea folder...?

pH-7 reviewed Nov 3, 2021

View reviewed changes

.idea/.name Outdated Show resolved Hide resolved

TT-talhatariq added 2 commits November 5, 2021 19:57

final code

796bded

final code

7cd539a

TT-talhatariq commented Nov 5, 2021

View reviewed changes

pH-7 reviewed Nov 6, 2021

View reviewed changes

pH-7 assigned TT-talhatariq and unassigned TT-talhatariq Nov 9, 2021

Jar File

e5d934c

TT-talhatariq commented Nov 9, 2021

View reviewed changes

pH-7 merged commit 6d9e330 into pH-7:master Nov 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code Improved and Bug Fixed #39

Code Improved and Bug Fixed #39

TT-talhatariq commented Sep 7, 2021

pH-7 commented Nov 3, 2021

pH-7 commented Nov 3, 2021 •

edited

Loading

pH-7 Nov 3, 2021

TT-talhatariq commented Nov 5, 2021

TT-talhatariq left a comment

pH-7 commented Nov 6, 2021

pH-7 left a comment •

edited

Loading

pH-7 Nov 6, 2021 •

edited

Loading

TT-talhatariq Nov 9, 2021

pH-7 commented Nov 6, 2021 •

edited

Loading

pH-7 commented Nov 9, 2021

TT-talhatariq left a comment

pH-7 commented Nov 21, 2021

pH-7 commented Nov 21, 2021

pH-7 commented Nov 21, 2021 •

edited

Loading

TT-talhatariq commented Nov 21, 2021

TT-talhatariq commented Nov 21, 2021

pH-7 commented Nov 25, 2021

Code Improved and Bug Fixed #39

Code Improved and Bug Fixed #39

Conversation

TT-talhatariq commented Sep 7, 2021

pH-7 commented Nov 3, 2021

pH-7 commented Nov 3, 2021 • edited Loading

pH-7 Nov 3, 2021

Choose a reason for hiding this comment

TT-talhatariq commented Nov 5, 2021

TT-talhatariq left a comment

Choose a reason for hiding this comment

pH-7 commented Nov 6, 2021

pH-7 left a comment • edited Loading

Choose a reason for hiding this comment

pH-7 Nov 6, 2021 • edited Loading

Choose a reason for hiding this comment

TT-talhatariq Nov 9, 2021

Choose a reason for hiding this comment

pH-7 commented Nov 6, 2021 • edited Loading

pH-7 commented Nov 9, 2021

TT-talhatariq left a comment

Choose a reason for hiding this comment

pH-7 commented Nov 21, 2021

pH-7 commented Nov 21, 2021

pH-7 commented Nov 21, 2021 • edited Loading

TT-talhatariq commented Nov 21, 2021

TT-talhatariq commented Nov 21, 2021

pH-7 commented Nov 25, 2021

pH-7 commented Nov 3, 2021 •

edited

Loading

pH-7 left a comment •

edited

Loading

pH-7 Nov 6, 2021 •

edited

Loading

pH-7 commented Nov 6, 2021 •

edited

Loading

pH-7 commented Nov 21, 2021 •

edited

Loading