[Feature Request] Webhooks for reactions on pull request review comments #20824
Replies: 42 comments 2 replies
-
|
Huge +1. Articulation for why this is important: People add reactions to issues as a way of expressing interest. To my knowledge there isn't a way to query the list of people who've subscribed to an issue and so instead we ask folks to add an emoji. This is better than asking them to comment because for issues with a large amount of interest, when people comment: "+1" it spams the inboxes of those currently subscribed. |
Beta Was this translation helpful? Give feedback.
-
|
Yes, this is correct!
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows
From: elvis ***@***.***>
Sent: Friday, July 22, 2022 12:28 PM
To: ***@***.***>
Cc: ***@***.***>
Subject: Re: [github-community/community] [Feature Request] Webhooks for reactions on pull request review comments (Discussion #20824)
Huge +1. Articulation for why this is important: People add reactions to issues as a way of expressing interest. To my knowledge there isn't a way to query the list of people who've subscribed to an issue and so instead we ask folks to add an emoji. This is better than asking them to comment because for issues with a large amount of interest, when people comment: "+1" it spams the inboxes of those currently subscribed.
—
Reply to this email directly, view it on GitHub<https://github.com/orgs/github-community/discussions/20824#discussioncomment-3208044>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKNOOWRVSFOLYKJIHVLAVLDVVLK2RANCNFSM535DC46Q>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
One other aspect of this is people often upvote an issue because they're interested in it. Up voting however doesn't automatically subscribe them to the issue and so if we were to later comment and close the issue they wouldn't know it's been fixed or closed unless they explicitly subscribed in addition to upvoting. |
Beta Was this translation helpful? Give feedback.
-
|
+1, are there any plans for the github team to build this out? Thanks. |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
+1 Me too I need it badly |
Beta Was this translation helpful? Give feedback.
-
|
+1 I too need this since i have automatic messages generated via Bots. To know whether those are really useful or not |
Beta Was this translation helpful? Give feedback.
-
|
+1, we need this feature as well as we want to automate surveys and polls in our GitHub pull requests! |
Beta Was this translation helpful? Give feedback.
-
|
+1, we were hoping to use a count of 👍 reactions to an auto-generated PR comment to trigger another workflow but it doesn't seem to be possible :( was hoping adding/removing a reaction would trigger |
Beta Was this translation helpful? Give feedback.
-
|
+1 This is badly needed :) |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
+1 - this is a critical webhook that would be extremely useful |
Beta Was this translation helpful? Give feedback.
-
|
+1 - this is a very useful feature. |
Beta Was this translation helpful? Give feedback.
-
|
+1 much needed |
Beta Was this translation helpful? Give feedback.
-
|
Let's just give at this point. I sadly doubt they'll ever do this 😢 😞 . |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
Emojis reaction wehbooks could help githup app developers create way more interactive experience in Github. |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
+1 We're building agentic workflows, and being able to ask for feedback easily and act on it quickly would be a huge improvement. |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
This is bonkers that this isn’t implemented. I know exactly the stupid rails controller where this lives and how to enable this. |
Beta Was this translation helpful? Give feedback.
-
|
Current State Webhooks exist for comments (issue_comment, pull_request_review_comment, commit_comment, etc.), but not for reactions on those comments. Adding/removing a reaction does not trigger any webhook. This has been raised before in the GitHub community (including the thread you mentioned about issue comments), but so far there’s no official support. |
Beta Was this translation helpful? Give feedback.
-
|
+100 |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Our GitHub app listens for webhooks on pull request review comment activity (created, updated, deleted) to avoid polling the pull request API.
We'd like to receive similar webhooks for comment reactions to avoid polling the reactions API. Unfortunately, it doesn't look like a webhook exists for when someone adds a reaction.
Just off the top of my head, either one of these would work:
pull_request_review_commentevent when a reaction is added to or removed from a commentAdding this would reduce the load on the API and I think many other developers would find it useful (here's a similar thread for issue comments).
Thanks!
Beta Was this translation helpful? Give feedback.
All reactions