Allow PR reviewers to comment on *unchanged* files #9099
Replies: 131 comments 33 replies
-
|
I have a use case in hand that could be solved by this proposed change. I have a PR that makes some small changes in a specific area of the codebase. This whole area was added recently, but for unrelated reasons, I've not had an opportunity to review this whole area at all when it was added. And since the current PR has drawn my attention to this - I want to use this opportunity, expand the scope of PR and review the whole newly added area altogether, including files that haven't been changed by this specific PR in hand. This is similar to a code audit, i.e. situation where a review is needed on a codebase in it's present state, without any changes whatsoever, but I guess it would be much easier to allow commenting on any files within a context of PR than to invent a whole new concept of a code audit outside of PR context. |
Beta Was this translation helpful? Give feedback.
-
|
Yea this is a much needed feature. Some codebases can be complex and good reviews might quickly grow in scope from just the changes of the dev to a much larger set if the PR being reviewed touches/interacts with many systems indirectly |
Beta Was this translation helpful? Give feedback.
-
|
I gree this would be very useful as well, has there been any update on this proposed feature? |
Beta Was this translation helpful? Give feedback.
-
|
Extremely necessary for translators – when you need to correct mistakes in an already existing translation file, but missed by the author of an already opened PR. |
Beta Was this translation helpful? Give feedback.
-
|
I have another use case for this. A PR contained changes that caused stale code in another file. I couldn't add a comment on the stale code in my PR review. |
Beta Was this translation helpful? Give feedback.
-
|
I would also like to have this feature. I frequently find myself needing to do this. |
Beta Was this translation helpful? Give feedback.
-
|
This would be very useful for large codebases in which old code needed to be removed/changed but was not... having to reference a line # and/or link to the code in a comment is very inconvenient. |
Beta Was this translation helpful? Give feedback.
-
|
Agreed that this would be critically useful. It would be great to see this happen! |
Beta Was this translation helpful? Give feedback.
-
|
Adding my support to this request, for exactly the reason brought up by @jordanbtucker |
Beta Was this translation helpful? Give feedback.
-
|
Really surprised this doesn't exist tbh - I thought I simply didn't know how to find it. But yes, it's extremely common during a PR review to find that a dev missed some related changes elsewhere in the codebase, & it seems currently there's no way to flag those. i.e. maybe they're refactoring references to a particular entity, but missed one of those references. As far as I can tell, there's no way to propose that as a change, in the spot where it actually needs to happen. |
Beta Was this translation helpful? Give feedback.
-
|
Surprised that this feature does not exist in the most widely used collaboration tool in 2022. Would love to have it, could help a lot to improve the PR review experiences. |
Beta Was this translation helpful? Give feedback.
-
|
Wanted to add a code suggestion that needed certain configuration in a file that wasn't changed. Felt unnatural to not be able to add this during the review but in another comment. |
Beta Was this translation helpful? Give feedback.
-
|
+1 In a PR I want to indicate that some code should be deleted, but since it wasn't touched, there's no way to do so. |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
It is incredibly disappointing that this still isn't implemented. |
Beta Was this translation helpful? Give feedback.
-
|
This really needs to be done, I liked that GitLab let us do this |
Beta Was this translation helpful? Give feedback.
-
|
+1 for this feature. My use case was that I was reviewing a pull request and found a seemingly obsolete file during the review. I didn't want to delete it right away, but it would have been nice to be able to add a comment on that file in the pull request. |
Beta Was this translation helpful? Give feedback.
-
|
Adding my support here as well |
Beta Was this translation helpful? Give feedback.
-
|
I find myself wanting to use this feature more than once a week, and I would really appreciate an update on this. |
Beta Was this translation helpful? Give feedback.
-
|
This is also a problem for PR authors. I've found myself resorting to adding whitespace in a file just to be able to add a comment there in the PR, and then deleting the whitespace once the comment is resolved. It's very roundabout and time-consuming. |
Beta Was this translation helpful? Give feedback.
-
|
Highly needed feature! |
Beta Was this translation helpful? Give feedback.
-
|
Highly needed, is there an ETA for implementation? |
Beta Was this translation helpful? Give feedback.
-
|
I'm not sure what the folks at GitHub are doing, but this is definitely a feature that's long overdue. |
Beta Was this translation helpful? Give feedback.
-
|
Since I didn't see the following discussion mentioned, I want to throw it in this discussion lists under "What's missing?" the point
|
Beta Was this translation helpful? Give feedback.
-
|
"You need to make the same change on this line" is such a common usecase when discussing changes in a PR. A changeset discussion is often about changes NOT made. |
Beta Was this translation helpful? Give feedback.
-
|
This feature shipped: |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Allow PR review comments on files not included (unchanged) in a pull request. This is useful when a PR reviewer needs to tell the PR author about a change they may have missed in a file that was not changed in that pull request.
From @mabwah-arista
This discussion was split out from an existing, related discussion 4452 that focused on commenting on any line of a changed file.
Beta Was this translation helpful? Give feedback.
All reactions