Improved pull request "Files Changed" experience feedback #163932
Replies: 2067 comments 701 replies
-
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
|
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
|
The tab for |
Beta Was this translation helpful? Give feedback.
-
|
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
On the Files changed tab I can only see 19 files out of 66. Why? |
Beta Was this translation helpful? Give feedback.
-
|
I used to be able to click on a useful link to see the submodule diff in PRs but now its just plain text. Could we have that back pls? |
Beta Was this translation helpful? Give feedback.
-
|
It doesn't always seem to remember if hide whitespace was turned on. |
Beta Was this translation helpful? Give feedback.
-
|
It seems like this view no longer gives you any indication that a file's extension was changed (I'm not sure if this applies to file renames generally). This PR renames a file from .js to .tsx which is obvious in the commit view (img 1) The new review page does not surface this as far as I can tell and it makes it look like there was a change to a |
Beta Was this translation helpful? Give feedback.
-
|
Please let me configure my review experience with two flags: First, to always open one file at a time, and Second, to always open the whole file (not just a few lines of context.) |
Beta Was this translation helpful? Give feedback.
-
|
I like the newer comment indicators and views, especially when submitting a PR. However, performance is abhorrent. It was bad before and now it's worse than molasses. I'm on a MacBook M4 pro and should not have to wait 10s of seconds after clicking "comment" to have the ui indicate it's even working. Additionally, I often tab between the browser and my ide to view code in context and the new gh experience likes to jump around when I do so. |
Beta Was this translation helpful? Give feedback.
-
|
We lose our linter warnings with the "new experience" mode in the diff. (Code is in TS) |
Beta Was this translation helpful? Give feedback.
-
|
For some reason, for one line change, it's not showing the diff: Switching back to the old one works. |
Beta Was this translation helpful? Give feedback.
-
|
Generally I'm loving the new experience. There is just one thing I've found a bit awkward. I love the 'focussed mode' when reviewing larger PR's. It actually helps a lot to just focus on a single file at a time. But I also really like marking files as 'viewed' as I review them, and this isn't so useful with the 'focussed single file' mode. It is not easy to find the files that have not yet been marked as 'viewed'. The best I have found is to cycle through every file. Perhaps an indicator of 'viewed' could be added to the file list on the right. I like how clicking 'viewed' moves to the next file. Perhaps there could be a setting that made it so that when this was done it moved to the next 'unviewed' file rather than just the next file. Perhaps you could also optionally choose to only cycle through 'unviewed files' with the left/right navigation. |
Beta Was this translation helpful? Give feedback.
-
|
Is it just me or GitHub feels more and more slower ? Is it because of React JS or chrome based browsers ? 🤔 |
Beta Was this translation helpful? Give feedback.
-
|
With large PRs for the one-file-at-a-time view to works loading needs to be instant. Clicking through 160 files when it takes a second to load each file view just doesn't work. On the whole I also don't think the one-file-at-a-time is really what users want. Often these large PRs come up due to refactors and then the changes per file is often < 5 lines. |
Beta Was this translation helpful? Give feedback.
-
|
Breaks even harder on large file changes than the old one. On the old one fans spin up and you're lucky if the tab doesn't freeze. On the new one it just flat out refuses to load the page. Neither are good experiences, I don't understand why either are so terribly slow the moment 30+ files are involved. Expanding "large diffs" also chokes any time really. |
Beta Was this translation helpful? Give feedback.
-
|
Unmarking a generated file with |
Beta Was this translation helpful? Give feedback.
-
|
The "Checkout with Github Desktop" button recently stopped opening the Github Desktop application and instead redirects to the https://github.com/apps/desktop web page. I switched back to the old UI and the button worked again. |
Beta Was this translation helpful? Give feedback.
-
would be nice to have same color on new experience thanks |
Beta Was this translation helpful? Give feedback.
-
|
Hmm, not really keen on the new single-file mode, as it makes cross-referencing things between files much more difficult as you have to switch back and forth instead of being able to load everything in, and then search the whole page. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
It's painfully slow for me on Safari 26.0.1 / macOS 26.0.1, I'm also experiencing huge delays between clicks and and their effect on the page, especially for PRs that go beyond a few lines. |
Beta Was this translation helpful? Give feedback.

























Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Important
You can opt in to the public preview from any pull request via
✨Try the new experiencein the upper-right corner. You can return to the classic view by clicking the “switch back” link.About the new experience
This refresh focuses on performance, accessibility, and clarity so reviews stay responsive—even on the largest pull requests.
What’s new ?
Performance 🚀
UX ✨
Accessibility
What's missing? 🟨
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
Beta Was this translation helpful? Give feedback.
All reactions