GitHub Community
Reminding someone to review your pull request #21550
-
|
After making changes to a pull request, what is the GitHub etiquette for notifying someone to take a look at the PR again? Should I write a comment @mentioning them? Should I do nothing and wait until a maintainer notices and decides to review/merge? Is there another way? Thanks |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment
-
|
Anyone who previously reviewed your PR or is otherwise following the conversation will get a notification whenever you push new commits. So what I would do is wait for a bit and see if the reviewer responds to the notification, and if not, then politely @mention them again saying that you’ve implemented the requested changes. Hope that helps :slight_smile: |
Beta Was this translation helpful? Give feedback.
Anyone who previously reviewed your PR or is otherwise following the conversation will get a notification whenever you push new commits. So what I would do is wait for a bit and see if the reviewer responds to the notification, and if not, then politely @mention them again saying that you’ve implemented the requested changes. Hope that helps :slight_smile: