BUG: PR viewed files not working properly #16811
-
|
When reviewing a PR, the viewed files feature seems to be working incorrectly. For example, when viewing a PR for the first time, I will see the count correctly show that I have viewed 0 files, yet individual files will show up as viewed: Unchecking the box on the file that I haven't viewed yet will make the count go negative, and then the checkbox becomes disabled: This issue seems to affect existing PRs that I have already viewed some files on as well. Files that have been changed are marked as viewed even when I haven't viewed them yet. In the screenshot above, note how the "viewed files" count says 6, when more than 6 files are marked as viewed (in total, there are 15 files the UI marks as viewed, despite the count saying only 6 have been viewed). Could someone take a look to see what's causing this? It is making the PR process quite difficult as the UI is not properly showing us what we've already viewed, in some cases erroneously telling users they have viewed files they have not. This is not good for proper code review processes. |
Beta Was this translation helpful? Give feedback.
Replies: 32 comments 18 replies
-
|
Me and a coworker have both experienced this today. It was working fine for both of us yesterday. I have also observed erroneous "Changed since last view" tags on PRs I have never viewed. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
Same |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
Same for me. |
Beta Was this translation helpful? Give feedback.
-
|
This is a critical github bug, I hope the maintainer can fix this as soon as possible! |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
I'm having the same problem. It seems related to the status of the |
Beta Was this translation helpful? Give feedback.
-
|
+1 for me and my colleagues |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
No need to reply to this thread with "+1" -- you can upvote the top message: Or click Subscribe to get email updates on the thread: |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
Does not seem to help it anyway... Github thinks this is normal: |
Beta Was this translation helpful? Give feedback.
-
|
I've faced the same today. |
Beta Was this translation helpful? Give feedback.
-
|
Negative files viewed. |
Beta Was this translation helpful? Give feedback.
-
|
The same issue I faced. Please, fix ASAP |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
The issue seems to be resolved for me and others that I've spoken to/have posted here, as of a few hours ago. |
Beta Was this translation helpful? Give feedback.















The issue seems to be resolved for me and others that I've spoken to/have posted here, as of a few hours ago.