GitHub Community
BUG: PR viewed files not working properly #16811
-
|
When reviewing a PR, the viewed files feature seems to be working incorrectly. For example, when viewing a PR for the first time, I will see the count correctly show that I have viewed 0 files, yet individual files will show up as viewed:
Unchecking the box on the file that I haven't viewed yet will make the count go negative, and then the checkbox becomes disabled:
This issue seems to affect existing PRs that I have already viewed some files on as well. Files that have been changed are marked as viewed even when I haven't viewed them yet.
In the screenshot above, note how the "viewed files" count says 6, when more than 6 files are marked as viewed (in total, there are 15 files the UI marks as viewed, despite the count saying only 6 have been viewed). Could someone take a look to see what's causing this? It is making the PR process quite difficult as the UI is not properly showing us what we've already viewed, in some cases erroneously telling users they have viewed files they have not. This is not good for proper code review processes. |
Beta Was this translation helpful? Give feedback.
Replies: 32 comments 18 replies
-
|
Me and a coworker have both experienced this today. It was working fine for both of us yesterday. I have also observed erroneous "Changed since last view" tags on PRs I have never viewed. |
Beta Was this translation helpful? Give feedback.
-
|
I almost merged several PRs because I thought I'd already reviewed other files when in reality I'd never even reviewed them at all 🤦♂️ A dev on my team also saw this lovely gem: This bug is badddddd... I hope they get it resolved ASAP because it's really negatively impacting my code reviews 😢 |
Beta Was this translation helpful? Give feedback.
-
|
Got the same issue for one of my PR, where on first landing on the Files Changed page, showed all files as viewed. If I uncheck the file, it shows the file changes/diff and a negative viewed number and I cannot click Viewed again |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
I am too facing the same. |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
Same for me: |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
Same |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
Same for me. |
Beta Was this translation helpful? Give feedback.
-
|
This is a critical github bug, I hope the maintainer can fix this as soon as possible! |
Beta Was this translation helpful? Give feedback.
-
|
Already report this in github ticket. |
Beta Was this translation helpful? Give feedback.
-
|
Can you please post the ticket here? 🙏 |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
I'm having the same problem. It seems related to the status of the
|
Beta Was this translation helpful? Give feedback.
-
|
@github-staff please post the public ticket link to fix this bug. And please provide ETA for fix |
Beta Was this translation helpful? Give feedback.
-
|
I confirm that |
Beta Was this translation helpful? Give feedback.
-
|
Created a personal bug ticket: https://support.github.com/ticket/personal/0/1630104 |
Beta Was this translation helpful? Give feedback.
-
|
+1 for me and my colleagues |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
No need to reply to this thread with "+1" -- you can upvote the top message:
Or click Subscribe to get email updates on the thread:
|
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
+1, the same problem |
Beta Was this translation helpful? Give feedback.
-
|
Please don't reply with "+1" -- do this instead: #16811 (comment) |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
Please don't reply with "+1" -- do this instead: #16811 (comment) |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
Please don't reply with "+1" -- do this instead: #16811 (comment) |
Beta Was this translation helpful? Give feedback.
-
|
Does not seem to help it anyway... Github thinks this is normal:
|
Beta Was this translation helpful? Give feedback.
-
|
Github might have some monitoring noticing when the entire thing falls down, but I doubt they have e.g. bots permanently hammering their infra trying to see if everything remains consistent (and having a project which makes pretty heavy use of the API, I can assure you that github is often inconsistent in the first place at short timescales). It's pretty common for things to start failing progressively and the status screen to remain "all green" until one of github's peeps finally notices the issue (/ gets a ticket), or the issue has spread enough that it affects most everyone. |
Beta Was this translation helpful? Give feedback.
-
|
I've faced the same today. |
Beta Was this translation helpful? Give feedback.
-
|
some of us have already done it, and an investigation is in-progress (screenshot is from today 11:30 BST) |
Beta Was this translation helpful? Give feedback.
-
|
Negative files viewed. |
Beta Was this translation helpful? Give feedback.
-
|
The same issue I faced. Please, fix ASAP |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
Please refresh. Seems to be fixed 1 minute ago |
Beta Was this translation helpful? Give feedback.
-
|
@sam-woodridge could you please check now too? |
Beta Was this translation helpful? Give feedback.
-
|
Seems to be fixed for me |
Beta Was this translation helpful? Give feedback.
-
|
The issue seems to be resolved for me and others that I've spoken to/have posted here, as of a few hours ago. |
Beta Was this translation helpful? Give feedback.
and others
The issue seems to be resolved for me and others that I've spoken to/have posted here, as of a few hours ago.