leave comment on file names #13013
-
|
I often want to leave pull request comments requesting a file name change. AFAICT there is no direct way to do this and so I always end up leaving a comment on the first line of the file instead. It would be a lot cleaner if I could leave a comment on the whole file (especially if i could do it as a code suggestion). |
Beta Was this translation helpful? Give feedback.
Replies: 6 comments
-
|
Similarly, sometimes a discussion is about the entire file, not any particular lines inside of it. We had the case recently where a whole file looked pretty ugly, but for fairly good reasons. On a PR comment, i'd like to reiterate those reasons, and be able to have a short discussion thread about that. But I'm limited to commenting on Line #1, and while it's often a code smell, Similarly, there's other parts of the PR to really review, and leaving just a top-level description on the PR doesn't point people at this important spot for discussion. |
Beta Was this translation helpful? Give feedback.
-
|
Does it sound reasonable to comment on the first line until we have such a feature? |
Beta Was this translation helpful? Give feedback.
-
|
Sometime a change is file rename only, which makes it impossible to leave comment on the first line of the file. It would great if there is a way to suggest a change to the file name/path. |
Beta Was this translation helpful? Give feedback.
-
|
Another use case I have for this is sometimes a PR contains a binary file change, for example a snapshot test having a reference image updated. I'd like the ability to comment on the binary file change. I currently cannot as there are no source code lines to start the comment. |
Beta Was this translation helpful? Give feedback.
-
|
Another use case, sometimes I want to comment on the location of the file so I have to comment on the first line and tell that |
Beta Was this translation helpful? Give feedback.
-
|
I noticed GitHub added this feature (actually partially, currently can only comment, not suggest change) today! #49954 |
Beta Was this translation helpful? Give feedback.
I noticed GitHub added this feature (actually partially, currently can only comment, not suggest change) today! #49954