Skip to content

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Sep 17, 2025

Signed-off-by: Attila Mészáros a_meszaros@apple.com

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri and others added 10 commits September 18, 2025 17:35
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
@csviri
Copy link
Collaborator Author

csviri commented Sep 18, 2025

@xstefank thank you very much, committed your suggestions

@csviri csviri requested a review from xstefank September 18, 2025 15:39
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri csviri requested a review from metacosm September 22, 2025 07:26
@metacosm
Copy link
Collaborator

Your last commit seems to have overwritten changes I made earlier.

@csviri
Copy link
Collaborator Author

csviri commented Sep 22, 2025

docs: improve wording

Sorry that was not intentional.
But pls don't do commits directly in to the PR, rather add suggestions.

@csviri
Copy link
Collaborator Author

csviri commented Sep 22, 2025

But will run some AI to rephrase it, so see it helps it.

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
Copy link
Collaborator Author

csviri commented Sep 22, 2025

Improved the workding and made some other fix. It is ready now. please review. Thank you!

@metacosm
Copy link
Collaborator

docs: improve wording

Sorry that was not intentional. But pls don't do commits directly in to the PR, rather add suggestions.

This would have taken way too long… and it already took me a long time to review so…

Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-incorporate the changes I made previously. Several of these changes were meant to clarify or correct things that I thought were not accurate enough or misleading. Using an AI tool is not going to address these issues (I see this already in the first sentence) and I'm not going to review this again when I've already done it once. I'll review the new final section again once this is done.

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
Copy link
Collaborator Author

csviri commented Sep 24, 2025

Please re-incorporate the changes I made previously. Several of these changes were meant to clarify or correct things that I thought were not accurate enough or misleading. Using an AI tool is not going to address these issues (I see this already in the first sentence) and I'm not going to review this again when I've already done it once. I'll review the new final section again once this is done.

I added most of you changes from that commit, they were all good, except one which I commented on. thank you!
pls review the last two sections.

@csviri csviri requested a review from metacosm September 24, 2025 08:47
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better explanations on a complex subject!

@csviri csviri merged commit 6c844bc into main Sep 25, 2025
24 of 25 checks passed
@csviri csviri deleted the data-access-docs branch September 25, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants