Nginx 1.9.11 ngx_udp_connection_t => ngx_resolver_connection_t

[charlesportwoodii]

Hi,

In Nginx 1.9.11, the ngx_udp_connection_t structure has been renamed to ngx_resolver_connection_t in src/core/ngx_resolver.h of Nginx core. (nginx/nginx@1945fff).

Consequently, compilation fails in lua-nginx-module/src/ngx_http_lua_socket_udp.h and lua-nginx-module/src/ngx_http_lua_socket_udp.c due to references of ngx_udp_connection_t. The compilation failure is as follows:

modules/lua-nginx-module/src/ngx_http_lua_util.c
In file included from modules/lua-nginx-module/src/ngx_http_lua_util.c:38:0:
modules/lua-nginx-module/src/ngx_http_lua_socket_udp.h:34:5: error: unknown type name ‘ngx_udp_connection_t’
     ngx_udp_connection_t             udp_connection;

I've attached a simple patch that corrects the issue and allows Nginx 1.9.11 to compile.

---

UPDATE: See #668 for others reporting this issue.

[nzt4567]

Great work!

[agentzh]

Style: the identifier names should be aligned up vertically. I think the ngx-releng tool in the nginx-devel-utils repos automatically catches coding style issues like this:

https://github.com/openresty/nginx-devel-utils

Will you please run this tool and fix any coding style issues? Thanks!

[charlesportwoodii]

@agentzh,

Sorry about the style. I've rebased an update that has the alignment issues correct.

Changes in this rebase:

• Changed connection back to udp_connection
• Styles

I'm not exactly sure what should be done regarding ngx_resolver_connection_t. In Nginx core, ngx_udp_connection_t was simply renamed to ngx_resolver_connection_t with some slight variation to the struct (connection was renamed to udp).

It may be beneficial to to create something like a ngx_http_lua_udp_connection_t struct, as that would be an easier place to put the macros in. My C is a little bit rusty though, and I just whipped this up to get Nginx to compile again. I'll try playing around with creating a re-usable and backwards compatible struct.

[agentzh]

@charlesportwoodii Thanks for your work on this. I'll continue thinking about the details here.

[charlesportwoodii]

@agentzh,

Glad to help out what little I can. Sorry for not being much more useful than this though. Preprocessor macros will be a pretty simple solution for the backwards compatibility aspect, but that would make a mess of src/ngx_http_lua_socket_udp.c and I wanted to avoid that as much as possible.

Let me know if I can help out in any other way.

[agentzh]

@charlesportwoodii Thanks for your help so far :) I'll look into this in the next couple of weeks. The next OpenResty release will be based on NGINX 1.9.11 anyway.

[agentzh]

The compilation error should be gone now. Thanks for the report!