feature: expose the 'Last-Modified' response header as ngx.header["Last-Modified"]. #1983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaocang
requested changes
Dec 30, 2021
| values[0].data = p; | ||
| values[0].len = ngx_http_time(p, last_modified) - p; | ||
| return 1; | ||
| } |
Contributor
There was a problem hiding this comment.
there should be a blank line before the break;
xiaocang
approved these changes
Dec 30, 2021
doujiang24
reviewed
Jan 1, 2022
| values[0].data = p; | ||
| values[0].len = ngx_http_time(p, last_modified) - p; | ||
| return 1; | ||
| } |
Member
There was a problem hiding this comment.
maybe we can return 0 here when the last_modified < 0? just for better performance.
src/ngx_http_lua_headers.c
Outdated
| break; | ||
|
|
||
| case 13: | ||
| last_modified = r->headers_out.last_modified_time; |
Member
There was a problem hiding this comment.
we should check if the key_buf is Last-Modified-time?
zhuizhuhaomeng
force-pushed
the
last_modified_header
branch
from
a97c90c to
6ceb395
Compare
doujiang24
reviewed
Jan 2, 2022
t/016-resp-header.t
Outdated
|
|
||
|
|
||
|
|
||
| === TEST 96: Expose the 'Last-Modified' response header as ngx.header["Last-Modified"] |
Member
There was a problem hiding this comment.
duplicated test name, better use a unique one.
Do you want to test the header is not existing?
src/ngx_http_lua_headers.c
Outdated
|
|
||
| case 13: | ||
| if (ngx_strncasecmp(key_buf, (u_char *) "Last-Modified", 13) == 0) { | ||
|
|
doujiang24
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.
the original PR is #1384.
the ngx.header was rewrite via ffi. So need to rewrite this feature.