Skip to content

Add baseUrl support #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 28, 2022
Merged

Add baseUrl support #72

merged 9 commits into from
Mar 28, 2022

Conversation

oklas
Copy link
Owner

@oklas oklas commented Mar 28, 2022

Closes #10

@oklas oklas merged commit 80c8a06 into master Mar 28, 2022
@oklas
Copy link
Owner Author

oklas commented Mar 28, 2022

🎉 This PR is included in version react-app-alias-ex-v2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@oklas oklas added the released label Mar 28, 2022
@oklas
Copy link
Owner Author

oklas commented Mar 28, 2022

🎉 This PR is included in version react-app-alias-v2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@oklas oklas deleted the task-10 branch March 28, 2022 16:12
@thany
Copy link

thany commented Mar 31, 2022

@oklas It doesn't work in react-app-alias-ex.

When I log the output of aliasWebpack(options)(config) I can see the baseUrl is completely ignored.
When I switch back to react-app-alias, and comment out the checkOutside(aliasMap) line, it does log the correct paths.

@oklas oklas mentioned this pull request Mar 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alias is not resolved based on baseUrl setting on tsconfig.paths.json
2 participants
@oklas @thany