Fix DivisionByZeroError when thread count is 0 #710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: DivisionByZeroError when Thread Count is 0
Problem
The application was crashing with a
DivisionByZeroError
when the configured number of threads was set to0
.This occurred during the calculation of file batch sizes for parallel processing.
Root Cause
The
$this->threads
value was being directly taken from configuration without validation.When it was
0
, the calculation:resulted in division by zero.
Solution
Added validation in the constructor to ensure the thread count is always at least 1:
Impact
Prevents application crashes when thread configuration is set to 0
Ensures reliable parallel processing with a minimum of 1 thread
Maintains backward compatibility with existing configurations
Testing
The fix ensures that even with threads: 0 in configuration, the application will run successfully with a single thread instead of crashing.