-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: remove numpy.distutils
usages from user-facing docs
#25597
Comments
<I'm a new wanna-be contributor. I've been looking into this issue as a stepping stone for understanding more about the Sphinx-generated documentation. I thought I'd add one or more comments/questions here as breadcrumbs for anyone who decides to tackle this Task.> When I grep through the .HTML files generated from my doc build, I see numpy.distutils appear on a huge number of pages. But that turns out to be only in the TOC sidebar. Question: Would a small but significant step in the right direction be to simply remove |
The f2py documentation page However, if we are to remove all references entirely, then various files in the Question: Is the best practice to keep on mentioning distutils but, as the f2py documentation does, point out it is going away and give all the better options? Or has the time come to simply delete distutils references entirely? |
Hi @eagunn, thanks for looking into this.
That should be the last task indeed - we should keep the docs as long as we install the
I'd say in all narrative docs/tutorials, we should remove |
Great feedback @rgommers . Thank you. I will prepare a PR to pull the As for the other pages, I will probably opt to do no harm. I don't know enough yet to translate the
|
Cc @HaoZeke as
That would be a quite useful contribution in itself, thank you. |
This all sounds like a good plan. Please feel free to ping me on any PRs arising from this effort for a review and also, @eagunn, I'd be happy to help with any issues arising from a translation on a draft PR as well. |
This is an installment in addressing ticket numpy#25597, tackling only the f2py documentation. This is a draft only. I will need some feedback on my edits before this change is ready for CI. [skip ci] [skip actions] [skip azp] [skip cirrus]
"Inventory" -- I'm traveling and not in a position to make/test changes, but I am reading through docs as I have time. My plan is to add to this comment as I find references to distutils that may need to be changed. NB: Items might already be resolved in some branch/PR; I'm checking them against main as I list them.
|
numpy.distutils
has been deprecated for a while, and there are better alternatives now. NumPy itself has switched to Meson. Thef2py
docs go above and beyond already and show how to use Meson, CMake and scikit-build: https://numpy.org/doc/stable/f2py/buildtools/index.html#build-systems.Here is one example that is still using
numpy.distutils
: https://numpy.org/doc/stable/user/c-info.ufunc-tutorial.html. There may be others. It'd be fine to keep some docs around that usesetuptools
instead ofnumpy.distutils
. The docs should probably simply use Meson in most places, and in cases that are more critical (like forf2py
) mention or show that both Meson/meson-python and CMake/scikit-build-core are good options.The text was updated successfully, but these errors were encountered: