Skip to content

fix: bump workspace dev deps with a deps commit #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2022
Merged

fix: bump workspace dev deps with a deps commit #225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b323f82
fix: bump workspace dev deps with a deps commit
lukekarrys Oct 5, 2022
8293bb8
fixup! fix: bump workspace dev deps with a deps commit
lukekarrys Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lib/release-please/node-workspace.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,13 @@ module.exports = class extends NodeWorkspace {
for (const [depName, resolved] of graphPackage.localDependencies) {
const depVersion = updatedVersions.get(depName)
const isNotDir = resolved.type !== 'directory'
// Changelog entries are only added for dependencies and not any other type
const isDep = Object.prototype.hasOwnProperty.call(pkg.dependencies, depName)
if (depVersion && isNotDir && isDep) {

// Due to some bugs in release-please we need to create `deps:` commits
// for all dev and prod dependencies even though we normally would only
// do a `chore:` commit to bump a dev dep. The tradeoff is an extra
// patch release to workspaces that depend on other workspaces as dev
// dependencies.
if (depVersion && isNotDir) {
commitsByPath[path].push({
message: `deps(${SCOPE}): ${depName} ${depVersion.toString()}`,
})
Expand Down