fix: break up greedy host fragment parsing regex #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's easier to reason about each step this way, and also not susceptible to redos.
jumoel
approved these changes
Nov 20, 2024
nishantms
approved these changes
Nov 20, 2024
Merged
wraithgar
added a commit
that referenced
this pull request
Nov 20, 2024
It's easier to reason about each step this way, and also not susceptible to redos.
wraithgar
pushed a commit
that referenced
this pull request
Nov 20, 2024
🤖 I have created a release *beep* *boop* --- ## [8.0.1](v8.0.0...v8.0.1) (2024-11-20) ### Bug Fixes * [`e47b7e4`](e47b7e4) [#274](#274) break up greedy host fragment parsing regex (#274) (@wraithgar) ### Chores * [`3d55d13`](3d55d13) [#277](#277) fix workflows for new backport branch (#277) (@wraithgar) * [`b3e455f`](b3e455f) [#273](#273) bump @npmcli/template-oss from 4.23.3 to 4.23.4 (#273) (@dependabot[bot], @npm-cli-bot) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
wraithgar
added a commit
that referenced
this pull request
Nov 21, 2024
It's easier to reason about each step this way, and also not susceptible to redos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easier to reason about each step this way, and also not susceptible
to redos.