docs: move and update inspector help#1216
docs: move and update inspector help#1216joshgav wants to merge 0 commit intonodejs:masterfrom joshgav:move-inspector-help
Conversation
|
cc @nodejs/diagnostics |
PR-URL: #1216 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
|
Landed in 13eaf4c. Thanks! |
|
I am concerned this landed without review from folks from the DevTools team. /cc @eugeneo @pavelfeldman. |
|
Sorry, didn't fully realize that we now have 2 copies of the "same" guide:
There's also overlap with the debugger docs page, specifically the "Advanced Usage" section. It might be good to do another pass to unify & cross-link to make sure each of the URLs provides value and we don't duplicate information. Imo iterating on the docs shouldn't have to block the node PR though as long as it points to a valid URL. |
|
@jkrems I left the old version up since it contains more detail in the first section which perhaps we can transition into a more complete guide. Such a guide could also include upcoming JS APIs (cc @eugeneo) and the Advanced usage you mentioned. Let's keep working on that and submit PRs with suggested updates. The doc in this PR is meant to be as short as possible and focus primarily on available tools per earlier feedback, to help users get started if they specify --inspect manually. In some ways it's a replacement for the chrome-devtools URL originally provided. Also it's to engender conversation about how to make this experience as good as possible for users, so thanks for the feedback 😄 @ofrobots would be great to get more feedback and suggestions from the DevTools and Chromium teams, please make follow-on PRs and we can get them merged quickly. Thank you! |
Per feedback in nodejs/node#11207, copying Inspector guide to a simpler path and removing background info.