test: add second argument to assert.throws()#9987
Closed
russokj wants to merge 1 commit intonodejs:masterfrom
Closed
test: add second argument to assert.throws()#9987russokj wants to merge 1 commit intonodejs:masterfrom
russokj wants to merge 1 commit intonodejs:masterfrom
Conversation
mscdex
added
the
events
imyller
added
the
code-and-learn
Contributor
|
Please see the commit message guidelines here. |
russokj
force-pushed
the
fix-throw-message
branch
from
d1bf102 to
791698a
Compare
russokj
changed the title
Contributor
Author
|
Updated the commit message to hopefully follow guidelines |
cjihrig
approved these changes
Dec 5, 2016
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
This is an improvement, but a regular expression would likely be better.
jasnell
requested changes
Dec 5, 2016
Member
There was a problem hiding this comment.
These checks would be more useful with a regexp as the second argument rather than simply Error:
assert.throws(function() {
e.setMaxListeners(NaN);
}, /^TypeError: "n" argument must be a positive number$/);
Member
The assert.throws() calls in test-event-emitter-max-listeners.js should include a constructor or RegExp as a second argument.
Trott
force-pushed
the
fix-throw-message
branch
from
791698a to
6c49a29
Compare
Member
Member
jasnell
approved these changes
Dec 24, 2016
jasnell
pushed a commit
that referenced
this pull request
Dec 24, 2016
The assert.throws() calls in test-event-emitter-max-listeners.js should include a constructor or RegExp as a second argument. PR-URL: #9987 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 1fddf5b |
Member
|
Thanks for the contribution @russokj! 🎉 |
targos
pushed a commit
that referenced
this pull request
Dec 26, 2016
The assert.throws() calls in test-event-emitter-max-listeners.js should include a constructor or RegExp as a second argument. PR-URL: #9987 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
Author
|
Just got back from vacation - thanks for making the changes. |
Merged
targos
pushed a commit
that referenced
this pull request
Dec 28, 2016
The assert.throws() calls in test-event-emitter-max-listeners.js should include a constructor or RegExp as a second argument. PR-URL: #9987 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
The assert.throws() calls in test-event-emitter-max-listeners.js should include a constructor or RegExp as a second argument. PR-URL: #9987 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
The assert.throws() calls in test-event-emitter-max-listeners.js should include a constructor or RegExp as a second argument. PR-URL: #9987 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 23, 2017
The assert.throws() calls in test-event-emitter-max-listeners.js should include a constructor or RegExp as a second argument. PR-URL: #9987 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
The assert.throws() calls in test-event-emitter-max-listeners.js should include a constructor or RegExp as a second argument. PR-URL: #9987 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 1, 2017
The assert.throws() calls in test-event-emitter-max-listeners.js should include a constructor or RegExp as a second argument. PR-URL: #9987 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
The assert throws() should include a constructor or RegExp as a second
argument.